Page MenuHomeFreeBSD
Differential D59404

sched_4bsd: remove obsolete comment
ClosedPublic
Actions

Authored by mchoo on Fri, Sep 4, 5:37 PM.
Tags
None
Referenced Files
F172987842: D59404.id.diff
Tue, Sep 22, 4:19 PM
Unknown Object (File)
Mon, Sep 21, 10:33 PM
Unknown Object (File)
Sat, Sep 19, 4:47 PM
Unknown Object (File)
Fri, Sep 18, 11:35 PM
Unknown Object (File)
Thu, Sep 17, 6:03 PM
Unknown Object (File)
Thu, Sep 17, 10:29 AM
Unknown Object (File)
Tue, Sep 15, 1:12 PM
Unknown Object (File)
Mon, Sep 14, 11:55 PM
View All 40 Files
Subscribers
imp
olce

Details

Reviewers
jhb
olce
Group Reviewers
scheduler
Commits
rG6c0c77e190b2: sched_4bsd: remove obsolete comment
Summary

'awake' checks if a thread, not a process, is awake.

MFC after: 2 weeks
MFC to: stable/14, stable/15
Sponsored by: FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 76600
Build 73483: arc lint + arc unit

Event Timeline

mchoo created this revision.Fri, Sep 4, 5:37 PM
Herald added subscribers: olce, imp. · View Herald TranscriptFri, Sep 4, 5:37 PM
mchoo requested review of this revision.Fri, Sep 4, 5:37 PM
Harbormaster completed remote builds in B76512: Diff 185840.Fri, Sep 4, 5:37 PM
mchoo mentioned this in D59405: sched_4bsd: remove obsolete comment.Fri, Sep 4, 5:41 PM
olce added a comment.Sun, Sep 6, 4:40 PM

Commit message: "As the comment doesn't reflect the code correctly, drop it." is superfluous, I'd just drop it.

mchoo updated this revision to Diff 186018.Sun, Sep 6, 6:43 PM

Reflect @olce's suggestion on commit message

Harbormaster completed remote builds in B76600: Diff 186018.Sun, Sep 6, 6:44 PM
mchoo edited the summary of this revision. (Show Details)Sun, Sep 6, 6:44 PM
mchoo added a parent revision: D59403: sched_4bsd: move comment to correct location.Sun, Sep 6, 6:46 PM
mchoo added a child revision: D59406: sched_4bsd: fix vague comment.
olce accepted this revision.Sun, Sep 6, 9:35 PM
This revision is now accepted and ready to land.Sun, Sep 6, 9:35 PM
Closed by commit rG6c0c77e190b2: sched_4bsd: remove obsolete comment (authored by mchoo). · Explain WhyFri, Sep 18, 2:15 PM
This revision was automatically updated to reflect the committed changes.
mchoo added a commit: rG6c0c77e190b2: sched_4bsd: remove obsolete comment.

Revision Contents
Changeset List

PathSize
sys/
kern/
6 lines

Diff 186018

View Options

sys/kern/sched_4bsd.c

Loading...