Page MenuHomeFreeBSD
Differential D59456

callout: provide callout_init_lock()
AcceptedPublic
Actions

Authored by glebius on Sat, Sep 5, 5:50 PM.
Tags
None
Referenced Files
F170965185: D59456.id.diff
Mon, Sep 7, 9:54 PM
F170933479: D59456.id186016.diff
Mon, Sep 7, 5:06 PM
F170933403: D59456.id186014.diff
Mon, Sep 7, 5:05 PM
F170932565: D59456.id186032.diff
Mon, Sep 7, 4:56 PM
F170932554: D59456.id186032.diff
Mon, Sep 7, 4:56 PM
F170918306: D59456.diff
Mon, Sep 7, 2:12 PM
F170918215: D59456.diff
Mon, Sep 7, 2:10 PM
F170915919: D59456.id185945.diff
Mon, Sep 7, 1:44 PM
View All 16 Files
Subscribers
imp
olce
ziaee

Details

Reviewers
kib
markj
Group Reviewers
Src Committers
Summary

This is type agnostic locked callout initializer. The callout_init_mtx()
and etc remain for compatibility.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76598
Build 73481: arc lint + arc unit

Event Timeline

glebius created this revision.Sat, Sep 5, 5:50 PM
Herald added subscribers: ziaee, olce, imp. · View Herald TranscriptSat, Sep 5, 5:50 PM
glebius requested review of this revision.Sat, Sep 5, 5:50 PM
Harbormaster completed remote builds in B76579: Diff 185945.Sat, Sep 5, 5:50 PM
glebius added a parent revision: D59455: locks: provide a macro to extract lock_object from various lock types.Sat, Sep 5, 5:50 PM
glebius added a child revision: D59457: buf_ring: support different lock classes.
glebius updated this revision to Diff 186014.Sun, Sep 6, 6:35 PM
  • Use _Generic() instead of transparent union
Harbormaster completed remote builds in B76596: Diff 186014.Sun, Sep 6, 6:36 PM
glebius mentioned this in D59455: locks: provide a macro to extract lock_object from various lock types.Sun, Sep 6, 6:36 PM
glebius updated this revision to Diff 186016.Sun, Sep 6, 6:40 PM
  • Reduce amount of changes.
Harbormaster completed remote builds in B76598: Diff 186016.Sun, Sep 6, 6:40 PM
glebius updated this revision to Diff 186032.Sun, Sep 6, 7:59 PM

Remove mention of lock_object_t in the manual page.

Harbormaster completed remote builds in B76606: Diff 186032.Sun, Sep 6, 7:59 PM
kib accepted this revision.Sun, Sep 6, 9:24 PM
kib added inline comments.
share/man/man9/callout.9
216
This revision is now accepted and ready to land.Sun, Sep 6, 9:24 PM
markj mentioned this in D59457: buf_ring: support different lock classes.Sun, Sep 6, 11:45 PM
markj accepted this revision.Mon, Sep 7, 1:10 PM
markj added inline comments.
share/man/man9/callout.9
198–199
247
267–268
sys/sys/callout.h
91

As in D59457, I think it'd be better to provide a helper macro in some central place, so that other consumers do not need to duplicate the selector which extracts the lock_object pointer.

Here, such a macro does not eliminate much code, but it'd still be a bit cleaner IMHO.

glebius updated this revision to Diff 186149.Mon, Sep 7, 5:38 PM
  • Manual page fixes.
  • Use lk2lo().
This revision now requires review to proceed.Mon, Sep 7, 5:38 PM
Harbormaster completed remote builds in B76644: Diff 186149.Mon, Sep 7, 5:38 PM
kib accepted this revision.Mon, Sep 7, 7:09 PM
This revision is now accepted and ready to land.Mon, Sep 7, 7:09 PM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
49 lines
sys/
sys/
14 lines

Diff 186016

View Options

share/man/man9/callout.9

Loading...
View Options

sys/sys/callout.h

Loading...