Differential D59456

callout: provide callout_init_lock()
ClosedPublic
Actions

Authored by glebius on Sat, Sep 5, 5:50 PM.

Tags

None

Referenced Files

	F172914490: D59456.diff
	Tue, Sep 22, 1:41 AM

	F172838423: D59456.id187148.diff
	Mon, Sep 21, 11:16 AM

	Unknown Object (File)
	Mon, Sep 21, 1:33 AM

	Unknown Object (File)
	Mon, Sep 21, 1:33 AM

	Unknown Object (File)
	Sun, Sep 20, 10:46 PM

	Unknown Object (File)
	Sun, Sep 20, 8:04 PM

	Unknown Object (File)
	Sat, Sep 19, 1:35 PM

	Unknown Object (File)
	Fri, Sep 18, 5:45 PM

View All 76 Files

Subscribers

Details

Reviewers

kib
markj

Group Reviewers

Commits

rG11d26e3c7e8e: callout: provide callout_init_lock()

Summary

This is type agnostic locked callout initializer. The callout_init_mtx()
and etc remain for compatibility.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76579
Build 73462: arc lint + arc unit

Event Timeline

glebius created this revision.Sat, Sep 5, 5:50 PM

Herald added subscribers: ziaee, olce, imp. · View Herald TranscriptSat, Sep 5, 5:50 PM

glebius requested review of this revision.Sat, Sep 5, 5:50 PM

Harbormaster completed remote builds in B76579: Diff 185945.Sat, Sep 5, 5:50 PM

glebius added a parent revision: D59455: locks: provide a macro to extract lock_object from various lock types.Sat, Sep 5, 5:50 PM

glebius added a child revision: D59457: buf_ring: support different lock classes.

Use _Generic() instead of transparent union

Harbormaster completed remote builds in B76596: Diff 186014.Sun, Sep 6, 6:36 PM

glebius mentioned this in D59455: locks: provide a macro to extract lock_object from various lock types.Sun, Sep 6, 6:36 PM

Reduce amount of changes.

Harbormaster completed remote builds in B76598: Diff 186016.Sun, Sep 6, 6:40 PM

Remove mention of lock_object_t in the manual page.

Harbormaster completed remote builds in B76606: Diff 186032.Sun, Sep 6, 7:59 PM

kib accepted this revision.Sun, Sep 6, 9:24 PM

kib added inline comments.

share/man/man9/callout.9
216

This revision is now accepted and ready to land.Sun, Sep 6, 9:24 PM

markj mentioned this in D59457: buf_ring: support different lock classes.Sun, Sep 6, 11:45 PM

markj accepted this revision.Mon, Sep 7, 1:10 PM

markj added inline comments.

share/man/man9/callout.9
198–199
247
267–268
sys/sys/callout.h
91	As in D59457, I think it'd be better to provide a helper macro in some central place, so that other consumers do not need to duplicate the selector which extracts the lock_object pointer. Here, such a macro does not eliminate much code, but it'd still be a bit cleaner IMHO.

Manual page fixes.
Use lk2lo().

This revision now requires review to proceed.Mon, Sep 7, 5:38 PM

Harbormaster completed remote builds in B76644: Diff 186149.Mon, Sep 7, 5:38 PM

kib accepted this revision.Mon, Sep 7, 7:09 PM

This revision is now accepted and ready to land.Mon, Sep 7, 7:09 PM

Closed by commit rG11d26e3c7e8e: callout: provide callout_init_lock() (authored by glebius). · Explain WhyFri, Sep 18, 9:32 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG11d26e3c7e8e: callout: provide callout_init_lock().

Revision Contents
Changeset List

Path

Size

share/

man/

man9/

49 lines

sys/

kern/

4 lines

sys/

12 lines

Diff 185945

share/man/man9/callout.9

Loading...

sys/kern/kern_timeout.c

Loading...

sys/sys/callout.h

Loading...