Page MenuHomeFreeBSD
Differential D59280

dtrace/arm: Fix and de-pessimize dtrace_copy
ClosedPublic
Actions

Authored by freebsd_dev.thsi.be on Sun, Aug 30, 10:51 PM.
Tags
None
Referenced Files
F171320647: D59280.id185502.diff
Thu, Sep 10, 9:43 AM
F171281805: D59280.id185460.diff
Thu, Sep 10, 2:55 AM
F171266179: D59280.id185706.diff
Wed, Sep 9, 11:42 PM
Unknown Object (File)
Wed, Sep 9, 7:34 AM
Unknown Object (File)
Tue, Sep 8, 3:46 PM
Unknown Object (File)
Tue, Sep 8, 2:39 PM
Unknown Object (File)
Tue, Sep 8, 12:46 PM
Unknown Object (File)
Tue, Sep 8, 6:58 AM
View All 40 Files
Subscribers
imp

Details

Reviewers
andrew
fuz
gnn
markj
Commits
rGc874d312e78f: dtrace/arm: Fix and de-pessimize dtrace_copy
Summary

Use an unprivileged load to access user memory from dtrace_copy, which
is running in SVC mode.

Abort the loop if the load is trapped, as it is useless, hence
wasteful, to keep faulting on successive addresses. I believe that
this de-pessimization should also be done on aarch64 and riscv.

PR: 298064
MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76339
Build 73222: arc lint + arc unit

Event Timeline

freebsd_dev.thsi.be created this revision.Sun, Aug 30, 10:51 PM
Herald added a subscriber: imp. · View Herald TranscriptSun, Aug 30, 10:51 PM
freebsd_dev.thsi.be requested review of this revision.Sun, Aug 30, 10:51 PM
Harbormaster completed remote builds in B76339: Diff 185460.Sun, Aug 30, 10:51 PM
freebsd_dev.thsi.be added a parent revision: D59279: sys/arm: Fix DTrace trap hook.Sun, Aug 30, 10:51 PM
freebsd_dev.thsi.be added a child revision: D59281: dtrace/arm: Really trap translation faults.
freebsd_dev.thsi.be updated this revision to Diff 185502.Mon, Aug 31, 5:46 PM
Harbormaster completed remote builds in B76354: Diff 185502.Mon, Aug 31, 5:46 PM
markj accepted this revision.Wed, Sep 2, 1:15 PM
This revision is now accepted and ready to land.Wed, Sep 2, 1:15 PM
Closed by commit rGc874d312e78f: dtrace/arm: Fix and de-pessimize dtrace_copy (authored by freebsd_dev.thsi.be, committed by markj). · Explain WhyThu, Sep 3, 3:05 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGc874d312e78f: dtrace/arm: Fix and de-pessimize dtrace_copy.
freebsd_dev.thsi.be mentioned this in D59341: dtrace/arm64: de-pessimize dtrace_copy.Thu, Sep 3, 3:13 PM

Revision Contents
Changeset List

PathSize
sys/
cddl/
dev/
dtrace/
arm/
11 lines

Diff 185460

View Options

sys/cddl/dev/dtrace/arm/dtrace_asm.S

Loading...