Page MenuHomeFreeBSD
Differential D59264

vt_simplefb: support armv7 and U-Boot-placed framebuffer nodes
Needs ReviewPublic
Actions

Authored by seuros on Sat, Aug 29, 3:05 PM.
Tags
Referenced Files
F170821391: D59264.diff
Sun, Sep 6, 8:30 PM
Unknown Object (File)
Sun, Sep 6, 5:49 AM
Unknown Object (File)
Sat, Sep 5, 11:38 PM
Unknown Object (File)
Sat, Sep 5, 1:48 PM
Unknown Object (File)
Sat, Sep 5, 11:36 AM
Unknown Object (File)
Sat, Sep 5, 9:29 AM
Unknown Object (File)
Sat, Sep 5, 3:42 AM
Unknown Object (File)
Fri, Sep 4, 8:34 PM
View All 22 Files
Subscribers
imp
mmel
oh
ray

Details

Reviewers
andrew
Group Reviewers
ARM
Summary

Search for simple-framebuffer nodes under both /chosen and the root,
as U-Boot may place them there, and skip disabled nodes.

Honor memory-region, fix address handling on 32-bit arm, and use the
pmap_preboot API for framebuffer mappings before pmap_bootstrap().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 76318
Build 73201: arc lint + arc unit

Event Timeline

seuros created this revision.Sat, Aug 29, 3:05 PM
Herald added a reviewer: andrew. · View Herald TranscriptSat, Aug 29, 3:05 PM
Herald added a subscriber: imp. · View Herald Transcript
seuros requested review of this revision.Sat, Aug 29, 3:05 PM
Harbormaster completed remote builds in B76318: Diff 185409.Sat, Aug 29, 3:05 PM
seuros added inline comments.Sat, Aug 29, 3:08 PM
sys/arm/arm/machdep.c
118

@imp , i saw that in some place we started to use booleans.

oh added a subscriber: oh.Sat, Aug 29, 3:43 PM
adrian added projects: drivers, ARM.Sat, Aug 29, 7:34 PM
adrian added a subscriber: ray.
ray added inline comments.Sat, Aug 29, 9:22 PM
sys/dev/vt/hw/simplefb/simplefb.c
153

I'm afraid not "/chosen" means it is not ready, in most cases. Or at least unwanted.

mmel added a subscriber: mmel.Sun, Aug 30, 6:32 AM

I'm not thrilled with this solution.
The standard pre-pmap_bootstrap() KVA is 128 MB, including:

  • kernel text/data/bss (section-mapped from KERNBASE);
  • early page tables (kern_pt1, kern_pt2tab and initial L2 pages);
  • whatever initarm() takes (dpcpu, stacks, msgbuf, etc.).

So there are only tens of megabytes of free KVA for the framebuffer.

mmel added a comment.Sun, Aug 30, 7:00 AM

Another thing: Wouldn't it be much cleaner to extend the implementation of pmap_mapdev_attr() for early boot phase of armv7? subr_devmap.c looks ready for this job.

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
2 lines
dev/
vt/
hw/
simplefb/
79 lines

Diff 185409

View Options

sys/arm/arm/machdep.c

Loading...
View Options

sys/dev/vt/hw/simplefb/simplefb.c

Loading...