Page MenuHomeFreeBSD

dwarves: Fix build on !__LP64__
ClosedPublic

Authored by cem on Jul 19 2016, 12:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 9:44 AM
Unknown Object (File)
Sat, Apr 27, 4:01 PM
Unknown Object (File)
Sat, Apr 27, 3:08 PM
Unknown Object (File)
Sat, Apr 27, 3:04 PM
Unknown Object (File)
Sat, Apr 27, 2:38 PM
Unknown Object (File)
Fri, Apr 26, 6:27 AM
Unknown Object (File)
Wed, Apr 24, 2:48 PM
Unknown Object (File)
Jan 1 2024, 7:56 PM
Subscribers
None

Details

Summary

Clang defines LP64 on such platforms, but not ILP32. Use
SIZEOF_LONG to detect long bits instead.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 4529
Build 4581: arc lint + arc unit

Event Timeline

cem retitled this revision from to dwarves: Fix build on !__LP64__.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: mat, bapt, bdrewery.

Before this patch do you have a runtime issue or does it just fail to build?

In D7236#150689, @bapt wrote:

Before this patch do you have a runtime issue or does it just fail to build?

It fails to build on i386.

For example, see:

http://package19.nyi.freebsd.org/build.html?mastername=103i386-default-build-as-user&build=418756

This is because the __ILP32__ define was only added on CURRENT in the stable/11 time frame. It doesn't exist on stable/10 or stable/9. Meanwhile, SIZEOF_LONG has existed since r210299 (predates stable/9).

Thanks for reviewing.

bapt edited edge metadata.

I just ask because a runtime failure would have mean a bump of the port revision, but a build fix does not need one

This revision is now accepted and ready to land.Jul 20 2016, 8:47 AM
This revision was automatically updated to reflect the committed changes.