dwarves: Fix build on !LP64
ClosedPublic
Actions

Authored by cem on Jul 19 2016, 12:13 AM.

Details

Reviewers

bapt
bdrewery
mat

Commits

rP418837: dwarves: Fix build on !__LP64__

Summary

Clang defines LP64 on such platforms, but not ILP32. Use
SIZEOF_LONG to detect long bits instead.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem updated this revision to Diff 18525.Jul 19 2016, 12:13 AM

cem retitled this revision from to dwarves: Fix build on !__LP64__.

cem updated this object.

cem edited the test plan for this revision. (Show Details)

cem added reviewers: mat, bapt, bdrewery.

Before this patch do you have a runtime issue or does it just fail to build?

In D7236#150689, @bapt wrote:

Before this patch do you have a runtime issue or does it just fail to build?

It fails to build on i386.

For example, see:

http://package19.nyi.freebsd.org/build.html?mastername=103i386-default-build-as-user&build=418756

This is because the __ILP32__ define was only added on CURRENT in the stable/11 time frame. It doesn't exist on stable/10 or stable/9. Meanwhile, SIZEOF_LONG has existed since r210299 (predates stable/9).

Thanks for reviewing.

I just ask because a runtime failure would have mean a bump of the port revision, but a build fix does not need one

This revision is now accepted and ready to land.Jul 20 2016, 8:47 AM

Closed by commit rP418837: dwarves: Fix build on !__LP64__ (authored by cem). · Explain WhyJul 20 2016, 2:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

devel/

dwarves/

files/

patch-dutil.h

6 lines

Diff 18592

View Options

head/devel/dwarves/files/patch-dutil.h

dwarves: Fix build on !__LP64__ClosedPublicActions