Page MenuHomeFreeBSD

dwarves: Fix build on !__LP64__
ClosedPublic

Authored by cem on Jul 19 2016, 12:13 AM.

Details

Summary

Clang defines LP64 on such platforms, but not ILP32. Use
SIZEOF_LONG to detect long bits instead.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cem updated this revision to Diff 18525.Jul 19 2016, 12:13 AM
cem retitled this revision from to dwarves: Fix build on !__LP64__.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: mat, bapt, bdrewery.
bapt edited edge metadata.Jul 19 2016, 11:02 AM

Before this patch do you have a runtime issue or does it just fail to build?

cem added a comment.Jul 19 2016, 3:12 PM
In D7236#150689, @bapt wrote:

Before this patch do you have a runtime issue or does it just fail to build?

It fails to build on i386.

cem added a comment.Jul 19 2016, 9:43 PM

For example, see:

http://package19.nyi.freebsd.org/build.html?mastername=103i386-default-build-as-user&build=418756

This is because the __ILP32__ define was only added on CURRENT in the stable/11 time frame. It doesn't exist on stable/10 or stable/9. Meanwhile, SIZEOF_LONG has existed since r210299 (predates stable/9).

Thanks for reviewing.

bapt accepted this revision.Jul 20 2016, 8:47 AM
bapt edited edge metadata.

I just ask because a runtime failure would have mean a bump of the port revision, but a build fix does not need one

This revision is now accepted and ready to land.Jul 20 2016, 8:47 AM
This revision was automatically updated to reflect the committed changes.