Page MenuHomeFreeBSD
Differential D7236

dwarves: Fix build on !__LP64__
ClosedPublic
Actions

Authored by cem on Jul 19 2016, 12:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 1 2024, 7:56 PM
Unknown Object (File)
Jan 1 2024, 7:55 PM
Unknown Object (File)
Jan 1 2024, 7:55 PM
Unknown Object (File)
Dec 29 2023, 4:44 PM
Unknown Object (File)
Dec 20 2023, 1:15 AM
Unknown Object (File)
Sep 11 2023, 12:28 PM
Unknown Object (File)
Jul 16 2023, 6:54 AM
Unknown Object (File)
Jun 27 2023, 9:09 AM
View All 22 Files
Subscribers
None

Details

Reviewers
bapt
bdrewery
mat
Commits
rP418837: dwarves: Fix build on !__LP64__
Summary

Clang defines LP64 on such platforms, but not ILP32. Use
SIZEOF_LONG to detect long bits instead.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 4529
Build 4581: arc lint + arc unit

Event Timeline

cem updated this revision to Diff 18525.Jul 19 2016, 12:13 AM
cem retitled this revision from to dwarves: Fix build on !__LP64__.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: mat, bapt, bdrewery.
bapt edited edge metadata.Jul 19 2016, 11:02 AM

Before this patch do you have a runtime issue or does it just fail to build?

cem added a comment.Jul 19 2016, 3:12 PM
In D7236#150689, @bapt wrote:

Before this patch do you have a runtime issue or does it just fail to build?

It fails to build on i386.

cem added a comment.Jul 19 2016, 9:43 PM

For example, see:

http://package19.nyi.freebsd.org/build.html?mastername=103i386-default-build-as-user&build=418756

This is because the __ILP32__ define was only added on CURRENT in the stable/11 time frame. It doesn't exist on stable/10 or stable/9. Meanwhile, SIZEOF_LONG has existed since r210299 (predates stable/9).

Thanks for reviewing.

bapt accepted this revision.Jul 20 2016, 8:47 AM
bapt edited edge metadata.

I just ask because a runtime failure would have mean a bump of the port revision, but a build fix does not need one

This revision is now accepted and ready to land.Jul 20 2016, 8:47 AM
Closed by commit rP418837: dwarves: Fix build on !__LP64__ (authored by cem). · Explain WhyJul 20 2016, 2:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
dwarves/
files/
6 lines

Diff 18525

View Options

devel/dwarves/files/patch-dutil.h

Loading...