Page MenuHomeFreeBSD
Differential D58961

nanobsd: Clean up target pkg database and metalog after install
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Wed, Aug 19, 10:20 AM.
Tags
None
Referenced Files
F168810514: D58961.id185265.diff
Sun, Aug 30, 6:36 AM
F168790814: D58961.id184835.diff
Sun, Aug 30, 4:23 AM
F168639449: D58961.diff
Sat, Aug 29, 9:34 AM
Unknown Object (File)
Fri, Aug 28, 10:20 PM
Unknown Object (File)
Fri, Aug 28, 10:15 PM
Unknown Object (File)
Fri, Aug 28, 3:49 PM
Unknown Object (File)
Fri, Aug 28, 12:30 PM
Unknown Object (File)
Fri, Aug 28, 12:24 PM
View All 36 Files
Subscribers
imp

Details

Reviewers
jlduran
jrm
ashish
Summary

Add _xxx_fix_pkg_permissions to fix the libsa.3.gz and /root permissions in the target pkg database until pkg metalog generation is fixed upstream, pkg_db_vacuum to verify and compact the target pkg database after the manual SQL edits, and _xxx_pkg_add_var_db_files_to_metalog to add the generated /var/db/pkg files to the metalog.

Also document _xxx_pkg_metalog's existing permission fixups by referencing the same upstream pkg issue.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76123
Build 73006: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Wed, Aug 19, 10:20 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 10:20 AM
senguptaangshuman17_gmail.com requested review of this revision.Wed, Aug 19, 10:20 AM
Harbormaster completed remote builds in B75714: Diff 184326.Wed, Aug 19, 10:20 AM
senguptaangshuman17_gmail.com added a parent revision: D58960: nanobsd: Fix target pkg database /tmp symlink and timestamps.Wed, Aug 19, 10:20 AM
senguptaangshuman17_gmail.com added a child revision: D58962: nanobsd: Rename code_slice to code_partition.
senguptaangshuman17_gmail.com updated this revision to Diff 184461.Thu, Aug 20, 10:10 AM
Harbormaster completed remote builds in B75795: Diff 184461.Thu, Aug 20, 10:10 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184512.Thu, Aug 20, 12:23 PM
Harbormaster completed remote builds in B75841: Diff 184512.Thu, Aug 20, 12:23 PM
senguptaangshuman17_gmail.com edited parent revisions, added: D59046: nanobsd: Add _xxx_pkg_db_vacuum; removed: D58960: nanobsd: Fix target pkg database /tmp symlink and timestamps.Thu, Aug 20, 12:33 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184753.Sat, Aug 22, 10:31 PM

Clean up merge conflict markers in defaults.sh

Harbormaster completed remote builds in B75971: Diff 184753.Sat, Aug 22, 10:31 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184835.Sun, Aug 23, 11:02 PM
Harbormaster completed remote builds in B76021: Diff 184835.Sun, Aug 23, 11:02 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184962.Tue, Aug 25, 6:10 AM
Harbormaster completed remote builds in B76085: Diff 184962.Tue, Aug 25, 6:10 AM
senguptaangshuman17_gmail.com updated this revision to Diff 185000.Tue, Aug 25, 8:00 AM

Rebase stack on top of D59043 update

Harbormaster completed remote builds in B76123: Diff 185000.Tue, Aug 25, 8:00 AM
jlduran added a comment.Wed, Aug 26, 3:38 PM

I think _xxx_pkg_db_dump_or_vacuum should be added sooner. In fact, I think this function should not be a _xxx_ function, as we will always want to verify the integrity of the pkg database before shipping our NanoBSD image, so I suggest "promoting" it to a regular pkg function (pkg_db_vacuum since it no longer dumps.) and including it in D58951.
I think the commit message in this revision also needs updating.

senguptaangshuman17_gmail.com edited parent revisions, added: D59045: nanobsd: Add _xxx_pkg_add_var_db_files_to_metalog; removed: D59046: nanobsd: Add _xxx_pkg_db_vacuum.Thu, Aug 27, 9:31 PM
senguptaangshuman17_gmail.com edited the summary of this revision. (Show Details)
senguptaangshuman17_gmail.com updated this revision to Diff 185265.Thu, Aug 27, 9:35 PM

Update cleanup helper to call pkg_db_vacuum

Harbormaster completed remote builds in B76255: Diff 185265.Thu, Aug 27, 9:35 PM
senguptaangshuman17_gmail.com updated this revision to Diff 185385.Sat, Aug 29, 9:29 AM
Harbormaster completed remote builds in B76300: Diff 185385.Sat, Aug 29, 9:29 AM

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
6 lines

Diff 185000

View Options

tools/tools/nanobsd/defaults.sh

Loading...