Page MenuHomeFreeBSD

nanobsd: Add _xxx_includes.subr
Needs ReviewPublic

Authored by senguptaangshuman17_gmail.com on Tue, Aug 18, 10:41 PM.
Tags
None
Referenced Files
F168884735: D58934.id.diff
Sun, Aug 30, 2:52 PM
F168867711: D58934.id185246.diff
Sun, Aug 30, 12:56 PM
F168794273: D58934.id184488.diff
Sun, Aug 30, 4:48 AM
F168736430: D58934.id184449.diff
Sat, Aug 29, 9:33 PM
F168704211: D58934.id.diff
Sat, Aug 29, 5:37 PM
Unknown Object (File)
Sat, Aug 29, 1:58 PM
Unknown Object (File)
Sat, Aug 29, 12:28 PM
Unknown Object (File)
Sat, Aug 29, 11:56 AM
Subscribers

Details

Reviewers
jrm
jlduran
ashish
Summary

Extract internal helper functions into _xxx_includes.subr.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76106
Build 72989: arc lint + arc unit

Event Timeline

_xxx_-prefixed functions are supposed to be removed at some point:
As explained in the last call, I would prefer if each _xxx_-prefixed function is introduced in a separate commit, with its associated pull request/bug report. In that way, we can simply revert that commit once the fix is implemented.
For example, the function _xxx_libarchive_mtree_bug() is no longer necessary in -CURRENT, but we still want it to land so we can MFC it into stable/15, after which we can just revert the commit that introduced it.
I would even add some witty comment at the beginning of the file along the lines of: # "Nothing is more permanent than a temporary solution" as encouragement, in lieu of # Functions in this file should be removed before submitting our changes upstream, as that ship has already sailed.

tools/tools/nanobsd/_xxx_includes.subr
13

Separate workarounds into dedicated commits and update header

_xxx_-prefixed functions are supposed to be removed at some point:
As explained in the last call, I would prefer if each _xxx_-prefixed function is introduced in a separate commit, with its associated pull request/bug report. In that way, we can simply revert that commit once the fix is implemented.
For example, the function _xxx_libarchive_mtree_bug() is no longer necessary in -CURRENT, but we still want it to land so we can MFC it into stable/15, after which we can just revert the commit that introduced it.
I would even add some witty comment at the beginning of the file along the lines of: # "Nothing is more permanent than a temporary solution" as encouragement, in lieu of # Functions in this file should be removed before submitting our changes upstream, as that ship has already sailed.

Addressed and commits splitted accordingly

This revision is now accepted and ready to land.Thu, Aug 20, 3:27 PM

As a side note, remember that the MAINTAINER of NanoBSD is @imp, so he must be tagged as a reviewer. He happens to be auto-subscribed to all revisions, but it is better to explicitly add him as a reviewer, at least for the crucial ones.
Thank you!

As a side note, remember that the MAINTAINER of NanoBSD is @imp, so he must be tagged as a reviewer. He happens to be auto-subscribed to all revisions, but it is better to explicitly add him as a reviewer, at least for the crucial ones.
Thank you!

ok will do so.

This revision now requires review to proceed.Sun, Aug 23, 11:00 PM

No code changes in this commit. An earlier commit in the stack (D58931) needed a commit-message reword per review feedback, which required a bottom-up arc diff refresh of every commit above it to keep the stack applying cleanly. That refresh is what reset this revision's accepted status, not a content change.

@jlduran, could you re-accept when you get a chance?