Paths

Table of Contentst

Differential D58966

nanobsd: Put customizations in a separate file
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Wed, Aug 19, 10:23 AM.

Tags

None

Referenced Files

	F168374112: D58966.diff
	Thu, Aug 27, 8:31 PM

	F168373828: D58966.diff
	Thu, Aug 27, 8:29 PM

	F168371838: D58966.diff
	Thu, Aug 27, 8:13 PM

	F168351286: D58966.diff
	Thu, Aug 27, 6:00 PM

	F168348756: D58966.diff
	Thu, Aug 27, 5:43 PM

	F168311270: D58966.id184563.diff
	Thu, Aug 27, 2:05 PM

	Unknown Object (File)
	Wed, Aug 26, 4:58 PM

	Unknown Object (File)
	Wed, Aug 26, 4:58 PM

View All 23 Files

Subscribers

Details

Reviewers

jlduran
jrm
ashish

Summary

Split the cust_*() functions out of defaults.sh into
customizations.sh and source it from nanobsd.sh.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76080
Build 72963: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Wed, Aug 19, 10:23 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 10:23 AM

senguptaangshuman17_gmail.com requested review of this revision.Wed, Aug 19, 10:23 AM

Harbormaster completed remote builds in B75719: Diff 184331.Wed, Aug 19, 10:23 AM

senguptaangshuman17_gmail.com added a parent revision: D58965: nanobsd: Rename NANO_PLAN gpt -> default, bump NANO_RAM_TMPVARSIZE.Wed, Aug 19, 10:23 AM

senguptaangshuman17_gmail.com added a child revision: D58967: nanobsd: Allow overriding kernels in loader.conf.

senguptaangshuman17_gmail.com updated this revision to Diff 184466.Thu, Aug 20, 10:11 AM

Harbormaster completed remote builds in B75800: Diff 184466.Thu, Aug 20, 10:11 AM

senguptaangshuman17_gmail.com updated this revision to Diff 184517.Thu, Aug 20, 12:23 PM

Harbormaster completed remote builds in B75846: Diff 184517.Thu, Aug 20, 12:23 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184563.Thu, Aug 20, 3:11 PM

Harbormaster completed remote builds in B75886: Diff 184563.Thu, Aug 20, 3:11 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184841.Sun, Aug 23, 11:03 PM

Harbormaster completed remote builds in B76027: Diff 184841.Sun, Aug 23, 11:03 PM

senguptaangshuman17_gmail.com edited parent revisions, added: D58964: nanobsd: Add gpt support; removed: D58965: nanobsd: Rename NANO_PLAN gpt -> default, bump NANO_RAM_TMPVARSIZE.Tue, Aug 25, 6:07 AM

senguptaangshuman17_gmail.com updated this revision to Diff 184957.Tue, Aug 25, 6:10 AM

Harbormaster completed remote builds in B76080: Diff 184957.Tue, Aug 25, 6:10 AM

Rebase stack on top of D59043 update

Harbormaster completed remote builds in B76128: Diff 185005.Tue, Aug 25, 8:00 AM

senguptaangshuman17_gmail.com updated this revision to Diff 185109.Tue, Aug 25, 9:01 PM

Harbormaster completed remote builds in B76168: Diff 185109.Tue, Aug 25, 9:01 PM

jlduran added inline comments.Wed, Aug 26, 4:30 PM

tools/tools/nanobsd/nanobsd.sh
43	Perhaps moving/placing this function (`is_defined()`) should be done the moment it is introduced (i.e., in D59166/D54187)? The same should be true for the sourcing of the files.

Clean up split customizations to only extract existing cust_* functions

Harbormaster completed remote builds in B76259: Diff 185269.Thu, Aug 27, 9:35 PM

Revision Contents
Changeset List

Path

Size

tools/

tools/

nanobsd/

customizations.sh

202 lines

135 lines

25 lines

Diff 184957

tools/tools/nanobsd/customizations.sh

Loading...

tools/tools/nanobsd/defaults.sh

Loading...

tools/tools/nanobsd/nanobsd.sh

Loading...