nvme: limit namespace character-device I/O size
ClosedPublic
Actions

Authored by seuros on Mon, Aug 24, 6:19 PM.

Details

Reviewers

adrian
imp
ngie

Commits

rG125ec0e30785: nvme: limit namespace character-device I/O size

Summary

The namespace character device does not initialize si_iosize_max, so
physio falls back to DFLTPHYS and can produce a bio larger than the
qpair payload DMA tag on a controller whose maximum transfer size is
below 64KB. Such a bio fails DMA mapping and is never submitted.

Approved by: ngie (co-mentor)
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 76057
Build 72940: arc lint + arc unit

Event Timeline

seuros created this revision.Mon, Aug 24, 6:19 PM

Herald added subscribers: dab, imp. · View Herald TranscriptMon, Aug 24, 6:19 PM

seuros requested review of this revision.Mon, Aug 24, 6:19 PM

Harbormaster completed remote builds in B76057: Diff 184920.Mon, Aug 24, 6:19 PM

seuros added a parent revision: D59151: nvme: complete requests when payload DMA mapping fails.Mon, Aug 24, 6:20 PM

seuros added reviewers: adrian, imp.

seuros added a child revision: D59153: nvme: name the Create I/O queue cdw11 fields, use Medium QPRIO.

imp accepted this revision.Mon, Aug 24, 10:27 PM

This revision is now accepted and ready to land.Mon, Aug 24, 10:27 PM

rebase

This revision now requires review to proceed.Tue, Aug 25, 6:34 AM

Harbormaster completed remote builds in B76111: Diff 184988.Tue, Aug 25, 6:34 AM

Could this be reproed using nvmecontrol reset? How can one confirm that the new value is being set properly? Asking as part of a "brain-storm" for a regression test of some kind.
Approved by: ngie (co-mentor)

This revision is now accepted and ready to land.Sat, Aug 29, 2:02 AM

seuros edited the summary of this revision. (Show Details)Tue, Sep 1, 6:28 PM

imp added inline comments.Tue, Sep 1, 7:44 PM