Page MenuHomeFreeBSD
Differential D59045

nanobsd: Add _xxx_pkg_add_var_db_files_to_metalog
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Thu, Aug 20, 12:22 PM.
Tags
None
Referenced Files
F168579736: D59045.id184998.diff
Sat, Aug 29, 2:59 AM
F168499553: D59045.id185264.diff
Fri, Aug 28, 5:09 PM
F168486853: D59045.id184814.diff
Fri, Aug 28, 3:38 PM
Unknown Object (File)
Thu, Aug 27, 11:55 PM
Unknown Object (File)
Thu, Aug 27, 8:31 PM
Unknown Object (File)
Thu, Aug 27, 8:29 PM
Unknown Object (File)
Thu, Aug 27, 8:13 PM
Unknown Object (File)
Thu, Aug 27, 7:20 PM
View All 27 Files
Subscribers
imp

Details

Reviewers
jlduran
jrm
ashish
Summary

Add /var/db/pkg generated files to metalog to address upstream pkg issue freebsd/pkg#2672.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76000
Build 72883: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Thu, Aug 20, 12:22 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Aug 20, 12:22 PM
senguptaangshuman17_gmail.com requested review of this revision.Thu, Aug 20, 12:22 PM
Harbormaster completed remote builds in B75839: Diff 184510.Thu, Aug 20, 12:22 PM
senguptaangshuman17_gmail.com added a parent revision: D59044: nanobsd: Add _xxx_fix_pkg_permissions.Thu, Aug 20, 12:33 PM
senguptaangshuman17_gmail.com added a child revision: D59046: nanobsd: Add _xxx_pkg_db_vacuum.
jlduran added a comment.Fri, Aug 21, 2:05 PM

I'm confused with the commit message: "since pkg generates them dynamically and does not emit them into package manifests."

  1. Dynamic generation is intrinsic to pkg.
  2. Perhaps most importantly is why we are doing this. It is because pkg does not generate a valid mtree (METALOG). All these metalog-related _xxx_ issues should point to https://github.com/freebsd/pkg/issues/2672.
senguptaangshuman17_gmail.com updated this revision to Diff 184814.EditedSun, Aug 23, 9:58 PM

Reworded commit message as per suggestion.

Harbormaster completed remote builds in B76000: Diff 184814.Sun, Aug 23, 9:58 PM
senguptaangshuman17_gmail.com edited the summary of this revision. (Show Details)Sun, Aug 23, 9:58 PM
jlduran added a comment.Mon, Aug 24, 12:13 PM

Please provide the full URL: https://github.com/freebsd/pkg/issues/2672 in the commit log.

tools/tools/nanobsd/_xxx_includes.subr
224
senguptaangshuman17_gmail.com updated this revision to Diff 184964.Tue, Aug 25, 6:11 AM
Harbormaster completed remote builds in B76087: Diff 184964.Tue, Aug 25, 6:11 AM
senguptaangshuman17_gmail.com edited the summary of this revision. (Show Details)Tue, Aug 25, 6:28 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184998.Tue, Aug 25, 7:59 AM

Rebase stack on top of D59043 update

Harbormaster completed remote builds in B76121: Diff 184998.Tue, Aug 25, 8:00 AM
senguptaangshuman17_gmail.com added a child revision: D58961: nanobsd: Clean up target pkg database and metalog after install.Thu, Aug 27, 9:31 PM
senguptaangshuman17_gmail.com edited the summary of this revision. (Show Details)
senguptaangshuman17_gmail.com updated this revision to Diff 185264.Thu, Aug 27, 9:35 PM

Reword commit message per review comment to cite freebsd/pkg#2672

Harbormaster completed remote builds in B76254: Diff 185264.Thu, Aug 27, 9:35 PM

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
13 lines

Diff 184814

View Options

tools/tools/nanobsd/_xxx_includes.subr

Loading...