Page MenuHomeFreeBSD
Differential D59067

netpfil tests: Make divapp packet loop handling opt-in
ClosedPublic
Actions

Authored by igoro on Fri, Aug 21, 11:33 AM.
Tags
None
Referenced Files
F171466990: D59067.id185200.diff
Fri, Sep 11, 6:51 AM
Unknown Object (File)
Thu, Sep 10, 8:45 PM
Unknown Object (File)
Wed, Sep 9, 3:08 AM
Unknown Object (File)
Tue, Sep 8, 6:11 PM
Unknown Object (File)
Mon, Sep 7, 11:33 PM
Unknown Object (File)
Mon, Sep 7, 4:34 PM
Unknown Object (File)
Sun, Sep 6, 3:19 PM
Unknown Object (File)
Sun, Sep 6, 1:25 PM
View All 53 Files
Subscribers
ae
donner
farrokhi
glebius
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
markj
Commits
rG36afb137b699: netpfil tests: Make divapp packet loop handling opt-in
Summary

This generalizes the divapp logic and makes it usable for other test
scenarios such as diverted TCP connections.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75932
Build 72815: arc lint + arc unit

Event Timeline

igoro created this revision.Fri, Aug 21, 11:33 AM
Herald added subscribers: vegeta_tuxpowered.net, glebius, donner and 4 others. · View Herald TranscriptFri, Aug 21, 11:33 AM
igoro requested review of this revision.Fri, Aug 21, 11:33 AM
Harbormaster completed remote builds in B75932: Diff 184632.Fri, Aug 21, 11:33 AM
igoro mentioned this in D59016: tests/pf: Make divapp more general.Fri, Aug 21, 11:35 AM
markj accepted this revision.Wed, Aug 26, 8:36 PM
markj added inline comments.
tests/sys/netpfil/common/divapp.c
144

You might add a comment here explaining that we are checking for packet loops here. That wasn't clear to me originally.

This revision is now accepted and ready to land.Wed, Aug 26, 8:36 PM
igoro marked an inline comment as done.Thu, Aug 27, 11:53 AM
igoro added inline comments.
tests/sys/netpfil/common/divapp.c
144

Totally agree. The comment should have been there in the first place.

Closed by commit rG36afb137b699: netpfil tests: Make divapp packet loop handling opt-in (authored by igoro). · Explain WhyThu, Aug 27, 11:55 AM
This revision was automatically updated to reflect the committed changes.
igoro marked an inline comment as done.
igoro added a commit: rG36afb137b699: netpfil tests: Make divapp packet loop handling opt-in.

Revision Contents
Changeset List

PathSize
tests/
sys/
netpfil/
common/
21 lines
ipfw/
12 lines
pf/
42 lines

Diff 184632

View Options

tests/sys/netpfil/common/divapp.c

Loading...
View Options

tests/sys/netpfil/ipfw/divert.sh

Loading...
View Options

tests/sys/netpfil/pf/divert-to.sh

Loading...