nanobsd: Add _xxx_pkg_add_var_db_files_to_metalog
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Thu, Aug 20, 12:22 PM.

Details

Reviewers

jlduran
jrm
ashish

Summary

pkg(8) does not generate a valid mtree/METALOG manifest for the contents
it creates under /var/db/pkg (see https://github.com/freebsd/pkg/issues/2672),
so those files are missing from NANO_METALOG.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75839
Build 72722: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Thu, Aug 20, 12:22 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Aug 20, 12:22 PM

senguptaangshuman17_gmail.com requested review of this revision.Thu, Aug 20, 12:22 PM

Harbormaster completed remote builds in B75839: Diff 184510.Thu, Aug 20, 12:22 PM

senguptaangshuman17_gmail.com added a parent revision: D59044: nanobsd: Add _xxx_fix_pkg_permissions.Thu, Aug 20, 12:33 PM

senguptaangshuman17_gmail.com added a child revision: D59046: nanobsd: Add _xxx_pkg_db_vacuum.

I'm confused with the commit message: "since pkg generates them dynamically and does not emit them into package manifests."

Dynamic generation is intrinsic to pkg.
Perhaps most importantly is why we are doing this. It is because pkg does not generate a valid mtree (METALOG). All these metalog-related _xxx_ issues should point to https://github.com/freebsd/pkg/issues/2672.