Differential D58654

ufshci: fail attribute reads on a non-zero config result code
ClosedPublic
Actions

Authored by jaeyoon on Aug 5 2026, 7:55 AM.

Tags

None

Referenced Files

	F170825509: D58654.diff
	Sun, Sep 6, 9:01 PM

	Unknown Object (File)
	Sat, Sep 5, 10:14 PM

	Unknown Object (File)
	Thu, Sep 3, 11:57 AM

	Unknown Object (File)
	Tue, Sep 1, 7:59 PM

	Unknown Object (File)
	Sat, Aug 29, 8:04 PM

	Unknown Object (File)
	Sat, Aug 29, 12:06 PM

	Unknown Object (File)
	Fri, Aug 28, 7:06 AM

	Unknown Object (File)
	Fri, Aug 28, 7:01 AM

View All 29 Files

Subscribers

None

Details

Reviewers

Commits

rG154e335cd635: ufshci: fail attribute reads on a non-zero config result code

Summary

ufshci_uic_send_cmd() only logged the error code and returned success,
so a failed DME_GET gave its caller a stale value as if it were valid.
The gear and lane settings could then be programmed from that garbage.

Return ENXIO for reads instead. Writes keep logging and continuing,
because a device may reject an optional attribute and that must not
fail bring-up.

Sponsored by: Samsung Electronics

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jaeyoon requested review of this revision.Aug 5 2026, 7:55 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75373: Diff 183417.Aug 5 2026, 7:55 AM

jaeyoon added a parent revision: D58653: ufshci: abort submission when payload DMA mapping fails.Aug 5 2026, 7:55 AM

jaeyoon added a child revision: D58655: ufshci: handle controller command submit failures.

imp accepted this revision.Aug 7 2026, 7:46 PM

This revision is now accepted and ready to land.Aug 7 2026, 7:46 PM

Closed by commit rG154e335cd635: ufshci: fail attribute reads on a non-zero config result code (authored by jaeyoon). · Explain WhyMon, Aug 10, 2:31 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rG154e335cd635: ufshci: fail attribute reads on a non-zero config result code.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

ufshci_uic_cmd.c

8 lines

Diff 183752

sys/dev/ufshci/ufshci_uic_cmd.c

Loading...