Page MenuHomeFreeBSD

ufshci: check SDB queue allocations for failure
ClosedPublic

Authored by jaeyoon on Wed, Aug 5, 8:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 28, 6:04 PM
Unknown Object (File)
Wed, Aug 26, 6:07 PM
Unknown Object (File)
Wed, Aug 26, 6:02 PM
Unknown Object (File)
Wed, Aug 26, 4:07 AM
Unknown Object (File)
Wed, Aug 26, 4:03 AM
Unknown Object (File)
Tue, Aug 25, 8:36 AM
Unknown Object (File)
Wed, Aug 19, 7:09 AM
Unknown Object (File)
Tue, Aug 18, 8:06 PM
Subscribers
None

Details

Summary

The hardware queue and ucd_bus_addr allocations use M_NOWAIT but were
used without a NULL check, and the payload bus_dmamap_create() return
value was ignored, so a failed allocation was only discovered by
faulting on it later. Fail the construction instead. The teardown
path handles the partially constructed queue.

Sponsored by: Samsung Electronics

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable