ufshci: initialize alloc_units before the dedicated-buffer scan
ClosedPublic
Actions

Authored by jaeyoon on Wed, Aug 5, 8:06 AM.

Details

Reviewers

Commits

rG456ab423dddc: ufshci: initialize alloc_units before the dedicated-buffer scan

Summary

If every unit descriptor read failed in the LU-dedicated WriteBooster
scan, alloc_units was used uninitialized. Start it at zero so that case
is treated as a zero-sized buffer and WriteBooster is disabled.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jaeyoon requested review of this revision.Wed, Aug 5, 8:06 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75382: Diff 183426.Wed, Aug 5, 8:06 AM

jaeyoon added a parent revision: D58662: ufshci: do not free the devq twice on SIM attach failure.Wed, Aug 5, 8:07 AM

jaeyoon added a child revision: D58664: ufshci: byte-swap big-endian UPIU fields.

imp accepted this revision.Fri, Aug 7, 7:52 PM

This revision is now accepted and ready to land.Fri, Aug 7, 7:52 PM

Closed by commit rG456ab423dddc: ufshci: initialize alloc_units before the dedicated-buffer scan (authored by jaeyoon). · Explain WhyMon, Aug 10, 2:31 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rG456ab423dddc: ufshci: initialize alloc_units before the dedicated-buffer scan.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

ufshci_dev.c

2 lines

Diff 183761

View Options

sys/dev/ufshci/ufshci_dev.c

ufshci: initialize alloc_units before the dedicated-buffer scanClosedPublicActions