Differential D58669

ufshci: release the CCB after sending a start stop unit command
ClosedPublic
Actions

Authored by jaeyoon on Wed, Aug 5, 8:12 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 30, 12:05 PM

	Unknown Object (File)
	Sun, Aug 30, 12:01 PM

	Unknown Object (File)
	Thu, Aug 27, 4:57 AM

	Unknown Object (File)
	Fri, Aug 21, 12:53 PM

	Unknown Object (File)
	Thu, Aug 20, 12:10 PM

	Unknown Object (File)
	Thu, Aug 20, 6:01 AM

	Unknown Object (File)
	Tue, Aug 18, 8:15 PM

	Unknown Object (File)
	Tue, Aug 18, 8:10 PM

View All 29 Files

Subscribers

None

Details

Reviewers

Commits

rGaaf0e80e684d: ufshci: release the CCB after sending a start stop unit command

Summary

ufshci_sim_send_ssu() got a CCB from cam_periph_getccb() but never
returned it. Each call leaked the CCB and one slot of the device's
CCB allocation budget. When the budget runs out, the next
cam_periph_getccb() waits forever and the suspend path hangs.

Release the CCB while the periph lock is still held, as the other CAM
periph drivers do.

Sponsored by: Samsung Electronics

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jaeyoon requested review of this revision.Wed, Aug 5, 8:12 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75387: Diff 183432.Wed, Aug 5, 8:12 AM

jaeyoon added a parent revision: D58668: ufshci: check completions under the queue lock.Wed, Aug 5, 8:13 AM

jaeyoon added a child revision: D58670: ufshci: free the taskqueue on detach.

imp accepted this revision.Fri, Aug 7, 7:55 PM

This revision is now accepted and ready to land.Fri, Aug 7, 7:55 PM

Closed by commit rGaaf0e80e684d: ufshci: release the CCB after sending a start stop unit command (authored by jaeyoon). · Explain WhyMon, Aug 10, 2:32 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rGaaf0e80e684d: ufshci: release the CCB after sending a start stop unit command.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

3 lines

Diff 183766

sys/dev/ufshci/ufshci_sim.c

Loading...