ufshci: initialize desc_size for non-descriptor query requests
ClosedPublic
Actions

Authored by jaeyoon on Wed, Aug 5, 8:09 AM.

Details

Reviewers

Commits

rGaf00e00f23a1: ufshci: initialize desc_size for non-descriptor query requests

Summary

The flag and attribute query builders left param.desc_size
uninitialized, so stack garbage was sent as the query UPIU length
field. Devices generally ignore the length for these opcodes, which
hid the bug. Zero it explicitly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jaeyoon requested review of this revision.Wed, Aug 5, 8:09 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75384: Diff 183429.Wed, Aug 5, 8:09 AM

jaeyoon added a parent revision: D58664: ufshci: byte-swap big-endian UPIU fields.Wed, Aug 5, 8:09 AM

jaeyoon added a child revision: D58667: ufshci: read UIC command results while holding the lock.

imp accepted this revision.Fri, Aug 7, 7:52 PM

This revision is now accepted and ready to land.Fri, Aug 7, 7:52 PM

Closed by commit rGaf00e00f23a1: ufshci: initialize desc_size for non-descriptor query requests (authored by jaeyoon). · Explain WhyMon, Aug 10, 2:32 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rGaf00e00f23a1: ufshci: initialize desc_size for non-descriptor query requests.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

ufshci_dev.c

5 lines

Diff 183763

View Options

sys/dev/ufshci/ufshci_dev.c

ufshci: initialize desc_size for non-descriptor query requestsClosedPublicActions