Page MenuHomeFreeBSD

ufshci: fail attribute reads on a non-zero config result code
Needs ReviewPublic

Authored by jaeyoon on Wed, Aug 5, 7:55 AM.

Details

Reviewers
imp
Summary

ufshci_uic_send_cmd() only logged the error code and returned success,
so a failed DME_GET gave its caller a stale value as if it were valid.
The gear and lane settings could then be programmed from that garbage.

Return ENXIO for reads instead. Writes keep logging and continuing,
because a device may reject an optional attribute and that must not
fail bring-up.

Sponsored by: Samsung Electronics

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75373
Build 72256: arc lint + arc unit