Page MenuHomeFreeBSD
Differential D58654

ufshci: fail attribute reads on a non-zero config result code
ClosedPublic
Actions

Authored by jaeyoon on Aug 5 2026, 7:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 8, 7:17 AM
Unknown Object (File)
Tue, Oct 6, 9:55 PM
Unknown Object (File)
Sat, Oct 3, 9:37 AM
Unknown Object (File)
Fri, Oct 2, 11:28 AM
Unknown Object (File)
Mon, Sep 21, 12:33 AM
Unknown Object (File)
Sun, Sep 20, 9:55 AM
Unknown Object (File)
Thu, Sep 17, 10:18 AM
Unknown Object (File)
Thu, Sep 17, 7:28 AM
View All 43 Files
Subscribers
None

Details

Reviewers
imp
Commits
rGd8ed29dcb9f3: ufshci: fail attribute reads on a non-zero config result code
rG154e335cd635: ufshci: fail attribute reads on a non-zero config result code
Summary

ufshci_uic_send_cmd() only logged the error code and returned success,
so a failed DME_GET gave its caller a stale value as if it were valid.
The gear and lane settings could then be programmed from that garbage.

Return ENXIO for reads instead. Writes keep logging and continuing,
because a device may reject an optional attribute and that must not
fail bring-up.

Sponsored by: Samsung Electronics

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
dev/
ufshci/
8 lines

Diff 183752

View Options

sys/dev/ufshci/ufshci_uic_cmd.c

Loading...