Differential D58654

ufshci: fail attribute reads on a non-zero config result code
ClosedPublic
Actions

Authored by jaeyoon on Wed, Aug 5, 7:55 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Aug 24, 4:22 PM

	Unknown Object (File)
	Sun, Aug 23, 2:36 PM

	Unknown Object (File)
	Fri, Aug 21, 5:17 AM

	Unknown Object (File)
	Thu, Aug 20, 8:43 PM

	Unknown Object (File)
	Thu, Aug 20, 4:41 PM

	Unknown Object (File)
	Wed, Aug 19, 9:28 PM

	Unknown Object (File)
	Tue, Aug 18, 9:02 PM

	Unknown Object (File)
	Tue, Aug 18, 8:31 PM

View All 21 Files

Subscribers

None

Details

Reviewers

Commits

rG154e335cd635: ufshci: fail attribute reads on a non-zero config result code

Summary

ufshci_uic_send_cmd() only logged the error code and returned success,
so a failed DME_GET gave its caller a stale value as if it were valid.
The gear and lane settings could then be programmed from that garbage.

Return ENXIO for reads instead. Writes keep logging and continuing,
because a device may reject an optional attribute and that must not
fail bring-up.

Sponsored by: Samsung Electronics

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jaeyoon requested review of this revision.Wed, Aug 5, 7:55 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75373: Diff 183417.Wed, Aug 5, 7:55 AM

jaeyoon added a parent revision: D58653: ufshci: abort submission when payload DMA mapping fails.Wed, Aug 5, 7:55 AM

jaeyoon added a child revision: D58655: ufshci: handle controller command submit failures.

imp accepted this revision.Fri, Aug 7, 7:46 PM

This revision is now accepted and ready to land.Fri, Aug 7, 7:46 PM

Closed by commit rG154e335cd635: ufshci: fail attribute reads on a non-zero config result code (authored by jaeyoon). · Explain WhyMon, Aug 10, 2:31 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rG154e335cd635: ufshci: fail attribute reads on a non-zero config result code.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

ufshci_uic_cmd.c

8 lines

Diff 183752

sys/dev/ufshci/ufshci_uic_cmd.c

Loading...