Differential D58664

ufshci: byte-swap big-endian UPIU fields
ClosedPublic
Actions

Authored by jaeyoon on Wed, Aug 5, 8:07 AM.

Tags

None

Referenced Files

	F170118462: D58664.id.diff
	Thu, Sep 3, 1:52 PM

	Unknown Object (File)
	Tue, Sep 1, 5:06 PM

	Unknown Object (File)
	Sun, Aug 30, 12:59 PM

	Unknown Object (File)
	Sun, Aug 30, 4:46 AM

	Unknown Object (File)
	Fri, Aug 28, 2:29 PM

	Unknown Object (File)
	Fri, Aug 28, 1:02 PM

	Unknown Object (File)
	Fri, Aug 28, 1:01 PM

	Unknown Object (File)
	Wed, Aug 26, 3:03 AM

View All 31 Files

Subscribers

None

Details

Reviewers

Commits

rG50a00f10d830: ufshci: byte-swap big-endian UPIU fields

Summary

The UPIU wire fields are big-endian. The task management and query
builders wrote host-order values into them. The completion paths also
read the results back without conversion. On a little-endian host an
ABORT_TASK carried a swapped task tag and LUN, a query carried a
swapped length, and attribute reads returned swapped values. Tolerant
devices masked most of the damage.

Convert with htobe*/be*toh at the wire boundary, as ufshci_sim.c
already does for its fields.

Sponsored by: Samsung Electronics

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75383
Build 72266: arc lint + arc unit

Event Timeline

jaeyoon requested review of this revision.Wed, Aug 5, 8:07 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75383: Diff 183427.Wed, Aug 5, 8:07 AM

jaeyoon added a parent revision: D58663: ufshci: initialize alloc_units before the dedicated-buffer scan.Wed, Aug 5, 8:08 AM

jaeyoon added a child revision: D58665: ufshci: initialize desc_size for non-descriptor query requests.

imp accepted this revision.Fri, Aug 7, 7:52 PM

This revision is now accepted and ready to land.Fri, Aug 7, 7:52 PM

Closed by commit rG50a00f10d830: ufshci: byte-swap big-endian UPIU fields (authored by jaeyoon). · Explain WhyMon, Aug 10, 2:31 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rG50a00f10d830: ufshci: byte-swap big-endian UPIU fields.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

ufshci_ctrlr_cmd.c

10 lines

2 lines

ufshci_req_queue.c

13 lines

Diff 183427

sys/dev/ufshci/ufshci_ctrlr_cmd.c

Loading...

sys/dev/ufshci/ufshci_dev.c

Loading...

sys/dev/ufshci/ufshci_req_queue.c

Loading...