Differential D58662

ufshci: do not free the devq twice on SIM attach failure
ClosedPublic
Actions

Authored by jaeyoon on Wed, Aug 5, 8:05 AM.

Tags

None

Referenced Files

	F169520525: D58662.diff
	Tue, Sep 1, 7:28 PM

	F169405096: D58662.id.diff
	Tue, Sep 1, 11:05 AM

	Unknown Object (File)
	Fri, Aug 28, 1:13 PM

	Unknown Object (File)
	Fri, Aug 28, 6:37 AM

	Unknown Object (File)
	Thu, Aug 27, 10:11 PM

	Unknown Object (File)
	Wed, Aug 26, 7:07 PM

	Unknown Object (File)
	Wed, Aug 26, 5:00 PM

	Unknown Object (File)
	Wed, Aug 26, 5:00 PM

View All 36 Files

Subscribers

None

Details

Reviewers

Commits

rGc71705a08304: ufshci: do not free the devq twice on SIM attach failure

Summary

cam_sim_free() with free_devq set already frees the devq, so the
following cam_simq_free() call on the xpt_bus_register() and
xpt_create_path() failure paths was a double free. Also clear
ctrlr->ufshci_sim so a later ufshci_sim_detach() does not operate on
the freed SIM.

Sponsored by: Samsung Electronics

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75381
Build 72264: arc lint + arc unit

Event Timeline

jaeyoon requested review of this revision.Wed, Aug 5, 8:05 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75381: Diff 183425.Wed, Aug 5, 8:05 AM

jaeyoon added a parent revision: D58661: ufshci: check SDB queue allocations for failure.Wed, Aug 5, 8:06 AM

jaeyoon added a child revision: D58663: ufshci: initialize alloc_units before the dedicated-buffer scan.

imp accepted this revision.Fri, Aug 7, 7:51 PM

This revision is now accepted and ready to land.Fri, Aug 7, 7:51 PM

Closed by commit rGc71705a08304: ufshci: do not free the devq twice on SIM attach failure (authored by jaeyoon). · Explain WhyMon, Aug 10, 2:31 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rGc71705a08304: ufshci: do not free the devq twice on SIM attach failure.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

5 lines

Diff 183425

sys/dev/ufshci/ufshci_sim.c

Loading...