Page MenuHomeFreeBSD
Differential D58555

ppp: Avoid overflow when formatting endpoint discriminator options
ClosedPublic
Actions

Authored by markj on Jul 30 2026, 3:03 PM.
Tags
None
Referenced Files
F169875665: D58555.id183111.diff
Wed, Sep 2, 8:55 PM
F169755944: D58555.id183317.diff
Wed, Sep 2, 11:31 AM
F169684591: D58555.diff
Wed, Sep 2, 7:10 AM
F169683392: D58555.diff
Wed, Sep 2, 7:06 AM
Unknown Object (File)
Tue, Sep 1, 9:28 PM
Unknown Object (File)
Tue, Sep 1, 6:28 PM
Unknown Object (File)
Tue, Sep 1, 10:47 AM
Unknown Object (File)
Mon, Aug 31, 11:48 AM
View All 68 Files
Subscribers
imp

Details

Reviewers
jhb
Group Reviewers
secteam
Commits
rG23deefa40b8d: ppp: Avoid overflow when formatting endpoint discriminator options
rG0cd984b41c2f: ppp: Avoid overflow when formatting endpoint discriminator options
rG561c1fc29b52: ppp: Avoid overflow when formatting endpoint discriminator options
rG281fb7d8a20b: ppp: Avoid overflow when formatting endpoint discriminator options
rG607c41d8f869: ppp: Avoid overflow when formatting endpoint discriminator options
rG78dfadaa0618: ppp: Avoid overflow when formatting endpoint discriminator options
rGe004ff15f87e: ppp: Avoid overflow when formatting endpoint discriminator options
Summary

Each byte of the address is represented by a pair of characters, so we
should be multiplying len by 2 when figuring out how much buffer space
we have.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jul 30 2026, 3:03 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 30 2026, 3:03 PM
markj requested review of this revision.Jul 30 2026, 3:03 PM
Harbormaster completed remote builds in B75294: Diff 183111.Jul 30 2026, 3:04 PM
markj added a parent revision: D58554: ppp: Reject invalid endpoint discriminator options.Jul 30 2026, 3:04 PM
markj updated this revision to Diff 183131.Jul 30 2026, 7:31 PM

Cast bytes to unsigned char, otherwise a negative byte will be sign
extended and occupy more than two bytes of the buffer.

Harbormaster completed remote builds in B75302: Diff 183131.Jul 30 2026, 7:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 3 2026, 3:23 PM
Closed by commit rGe004ff15f87e: ppp: Avoid overflow when formatting endpoint discriminator options (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGe004ff15f87e: ppp: Avoid overflow when formatting endpoint discriminator options.
markj added a commit: rG78dfadaa0618: ppp: Avoid overflow when formatting endpoint discriminator options.Thu, Aug 6, 3:02 PM
markj added a commit: rG607c41d8f869: ppp: Avoid overflow when formatting endpoint discriminator options.Fri, Aug 7, 12:42 PM
cperciva added a commit: rG281fb7d8a20b: ppp: Avoid overflow when formatting endpoint discriminator options.Thu, Aug 20, 5:54 PM
Herald added a reviewer: scheduler. · View Herald TranscriptThu, Aug 20, 5:54 PM
lwhsu removed a reviewer: scheduler.Thu, Aug 20, 8:12 PM
markj added a commit: rG561c1fc29b52: ppp: Avoid overflow when formatting endpoint discriminator options.Tue, Aug 25, 4:01 PM
markj added a commit: rG0cd984b41c2f: ppp: Avoid overflow when formatting endpoint discriminator options.
markj added a commit: rG23deefa40b8d: ppp: Avoid overflow when formatting endpoint discriminator options.

Revision Contents
Changeset List

PathSize
usr.sbin/
ppp/
12 lines

Diff 183317

View Options

usr.sbin/ppp/mp.c

Loading...