Page MenuHomeFreeBSD

xinstall: Const correctness for C23
ClosedPublic

Authored by ivy on Jul 27 2026, 10:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 1, 6:07 PM
Unknown Object (File)
Tue, Sep 1, 4:25 PM
Unknown Object (File)
Fri, Aug 28, 10:06 AM
Unknown Object (File)
Fri, Aug 28, 10:02 AM
Unknown Object (File)
Thu, Aug 27, 4:51 AM
Unknown Object (File)
Tue, Aug 25, 11:01 PM
Unknown Object (File)
Tue, Aug 25, 11:00 PM
Unknown Object (File)
Tue, Aug 25, 2:54 PM
Subscribers

Details

Summary

On some platforms, e.g. Linux Clang 22.1.8 / glibc 2.43, strchr()
now implements the C23 behaviour where passing a const pointer to
strchr() also returns a const pointer. This breaks xinstall during
the bootstrap build, since it assumes the return value is always
a mutable pointer.

As the returned pointer is never used to modify the value, fix this
by making the temporary variable const.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable