Page MenuHomeFreeBSD
Differential D58591

mtest: Use ntohl() when assigning IPv4-mapped addresses for IPv6 sockets.
AbandonedPublic
Actions

Authored by bms on Aug 2 2026, 1:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 3, 5:56 PM
Unknown Object (File)
Thu, Sep 3, 2:37 AM
Unknown Object (File)
Tue, Sep 1, 7:22 AM
Unknown Object (File)
Thu, Aug 27, 3:34 PM
Unknown Object (File)
Thu, Aug 27, 12:51 PM
Unknown Object (File)
Sun, Aug 23, 10:09 PM
Unknown Object (File)
Sun, Aug 23, 12:16 AM
Unknown Object (File)
Fri, Aug 21, 9:08 PM
View All 28 Files
Subscribers
imp
zlei
network

Details

Reviewers
glebius
imp
adrian
pouria
Summary

Direct assignments to C integer array members are in host endianness,
so preserve network endianness of a value returned by getnameinfo().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75336
Build 72219: arc lint + arc unit

Event Timeline

bms created this revision.Aug 2 2026, 1:15 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 2 2026, 1:15 PM
bms requested review of this revision.Aug 2 2026, 1:15 PM
Harbormaster completed remote builds in B75336: Diff 183228.Aug 2 2026, 1:15 PM
bms added a parent revision: D58589: mtest: Add support for exercising IPv4-mapped groups on IPv6 sockets..Aug 2 2026, 1:15 PM
bms added reviewers: glebius, imp, adrian, pouria.
bms added a subscriber: network.
zlei added a subscriber: zlei.Aug 2 2026, 6:46 PM
zlei added inline comments.
usr.sbin/mtest/mtest.c
162

Emm, the internet addresses ( in this case both a4 and a6 ) shall always be stored with network byte order. So is this extra ntohl really required ?

bms added a comment.Aug 2 2026, 8:06 PM

Good catch, this was being munged elsewhere. The ntohl() for the 0x0000FFFF component is definitely needed.

bms abandoned this revision.Aug 2 2026, 8:07 PM
bms mentioned this in D58590: netinet6: Fix two issues with passing v4-mapped groups to IPv6 sockets..Aug 2 2026, 8:37 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
mtest/
4 lines

Diff 183228

View Options

usr.sbin/mtest/mtest.c

Loading...