Page MenuHomeFreeBSD
Differential D58555

ppp: Avoid overflow when formatting endpoint discriminator options
ClosedPublic
Actions

Authored by markj on Jul 30 2026, 3:03 PM.
Tags
None
Referenced Files
F169121674: D58555.id183317.diff
Mon, Aug 31, 11:48 AM
Unknown Object (File)
Sun, Aug 30, 9:46 PM
Unknown Object (File)
Sun, Aug 30, 6:42 PM
Unknown Object (File)
Sun, Aug 30, 10:54 AM
Unknown Object (File)
Fri, Aug 28, 9:54 PM
Unknown Object (File)
Fri, Aug 28, 6:53 PM
Unknown Object (File)
Thu, Aug 27, 2:45 PM
Unknown Object (File)
Thu, Aug 27, 2:40 PM
View All 61 Files
Subscribers
imp

Details

Reviewers
jhb
Group Reviewers
secteam
Commits
rG23deefa40b8d: ppp: Avoid overflow when formatting endpoint discriminator options
rG0cd984b41c2f: ppp: Avoid overflow when formatting endpoint discriminator options
rG561c1fc29b52: ppp: Avoid overflow when formatting endpoint discriminator options
rG281fb7d8a20b: ppp: Avoid overflow when formatting endpoint discriminator options
rG607c41d8f869: ppp: Avoid overflow when formatting endpoint discriminator options
rG78dfadaa0618: ppp: Avoid overflow when formatting endpoint discriminator options
rGe004ff15f87e: ppp: Avoid overflow when formatting endpoint discriminator options
Summary

Each byte of the address is represented by a pair of characters, so we
should be multiplying len by 2 when figuring out how much buffer space
we have.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75294
Build 72177: arc lint + arc unit

Event Timeline

markj created this revision.Jul 30 2026, 3:03 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 30 2026, 3:03 PM
markj requested review of this revision.Jul 30 2026, 3:03 PM
Harbormaster completed remote builds in B75294: Diff 183111.Jul 30 2026, 3:04 PM
markj added a parent revision: D58554: ppp: Reject invalid endpoint discriminator options.Jul 30 2026, 3:04 PM
markj updated this revision to Diff 183131.Jul 30 2026, 7:31 PM

Cast bytes to unsigned char, otherwise a negative byte will be sign
extended and occupy more than two bytes of the buffer.

Harbormaster completed remote builds in B75302: Diff 183131.Jul 30 2026, 7:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Aug 3, 3:23 PM
Closed by commit rGe004ff15f87e: ppp: Avoid overflow when formatting endpoint discriminator options (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGe004ff15f87e: ppp: Avoid overflow when formatting endpoint discriminator options.
markj added a commit: rG78dfadaa0618: ppp: Avoid overflow when formatting endpoint discriminator options.Thu, Aug 6, 3:02 PM
markj added a commit: rG607c41d8f869: ppp: Avoid overflow when formatting endpoint discriminator options.Fri, Aug 7, 12:42 PM
cperciva added a commit: rG281fb7d8a20b: ppp: Avoid overflow when formatting endpoint discriminator options.Thu, Aug 20, 5:54 PM
Herald added a reviewer: scheduler. · View Herald TranscriptThu, Aug 20, 5:54 PM
lwhsu removed a reviewer: scheduler.Thu, Aug 20, 8:12 PM
markj added a commit: rG561c1fc29b52: ppp: Avoid overflow when formatting endpoint discriminator options.Tue, Aug 25, 4:01 PM
markj added a commit: rG0cd984b41c2f: ppp: Avoid overflow when formatting endpoint discriminator options.
markj added a commit: rG23deefa40b8d: ppp: Avoid overflow when formatting endpoint discriminator options.

Revision Contents
Changeset List

PathSize
usr.sbin/
ppp/
8 lines

Diff 183111

View Options

usr.sbin/ppp/mp.c

Loading...