Page MenuHomeFreeBSD

hyperv/vmbus: Cleanup channel sending
ClosedPublic

Authored by sepherosa_gmail.com on Jul 11 2016, 3:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 6:39 AM
Unknown Object (File)
Fri, Apr 26, 6:23 AM
Unknown Object (File)
Jan 24 2024, 5:19 AM
Unknown Object (File)
Jan 17 2024, 5:37 PM
Unknown Object (File)
Dec 22 2023, 1:18 PM
Unknown Object (File)
Dec 22 2023, 1:17 PM
Unknown Object (File)
Dec 20 2023, 3:08 AM
Unknown Object (File)
Dec 18 2023, 12:16 PM
Subscribers

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Cleanup channel sending.
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.
head/sys/dev/hyperv/vmbus/hv_channel.c
632 ↗(On Diff #18455)

Since you are already modifying this code, I would just use bool here (because it's shorter).

636 ↗(On Diff #18455)

All of the above should be size_t, and constified AFAICT (or at least const unsigned int).

649 ↗(On Diff #18455)

Adding this padding here is very ugly. Shouldn't the padding be added by hv_ring_buffer_write automatically? It seems open-coding this for every caller of hv_ring_buffer_write is very inefficient.

654 ↗(On Diff #18455)

return (error);