Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
head/sys/dev/hyperv/vmbus/hv_channel.c | ||
---|---|---|
632 ↗ | (On Diff #18455) | Since you are already modifying this code, I would just use bool here (because it's shorter). |
636 ↗ | (On Diff #18455) | All of the above should be size_t, and constified AFAICT (or at least const unsigned int). |
649 ↗ | (On Diff #18455) | Adding this padding here is very ugly. Shouldn't the padding be added by hv_ring_buffer_write automatically? It seems open-coding this for every caller of hv_ring_buffer_write is very inefficient. |
654 ↗ | (On Diff #18455) | return (error); |