Page MenuHomeFreeBSD
Differential D58393

getpgrp(2), getsid(2): allow to call on zombies
ClosedPublic
Actions

Authored by kib on Wed, Jul 22, 9:51 AM.
Tags
None
Referenced Files
F163545240: D58393.diff
Fri, Jul 24, 8:12 AM
Unknown Object (File)
Thu, Jul 23, 2:19 PM
Unknown Object (File)
Thu, Jul 23, 1:17 PM
Unknown Object (File)
Wed, Jul 22, 6:09 PM
Unknown Object (File)
Wed, Jul 22, 4:08 PM
Subscribers
arrowd
imp
olce

Details

Reviewers
markj
kevans
kib
Summary

Also be more protective in getsid().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Wed, Jul 22, 9:51 AM
Herald added subscribers: olce, imp. · View Herald TranscriptWed, Jul 22, 9:51 AM
kib requested review of this revision.Wed, Jul 22, 9:51 AM
markj added a comment.Wed, Jul 22, 6:14 PM

Why?

sys/kern/kern_prot.c
247–250

There is no corresponding check p->p_pgrp != NULL in sys_getpgid() above.

I suspect it's impossible to have a NULL p->p_pgrp or p->p_pgrp->pg_session.

kib added a comment.Wed, Jul 22, 9:02 PM
In D58393#1339635, @markj wrote:

Why?

https://gitlab.haskell.org/ghc/ghc/-/work_items/27512#note_686988
> But the hypothesis here is that getpgid on a zombie process fails, probably ESRCH.
sys/kern/kern_prot.c
247–250

For p_pgrp yes, it is only cleared on reap.
But for the pg_session, I am not sure. What makes me wonder is the number of checks for p->p_session != NULL in the tree.

kib added a subscriber: arrowd.Wed, Jul 22, 9:03 PM
markj added inline comments.Wed, Jul 22, 9:09 PM
sys/kern/kern_prot.c
247–250

Yeah, it's not very clear to me either. I suspect it is always non-NULL. e.g., pgdelete() will unconditionally dereference pg_session.

252
kib marked 2 inline comments as done.Wed, Jul 22, 10:01 PM
kib added inline comments.
sys/kern/kern_prot.c
247–250

I dropped the p_pgrp check, but kept pg_session. I think this should follow the existing pattern for now, and cleaned with the global sweep.

kib updated this revision to Diff 182485.Wed, Jul 22, 10:01 PM
kib marked 2 inline comments as done.

Return error.

markj accepted this revision.Thu, Jul 23, 1:21 PM
markj added inline comments.
sys/kern/kern_prot.c
252

Also need to initialize error to 0 for the pid == 0 case.

This revision is now accepted and ready to land.Thu, Jul 23, 1:21 PM
kib updated this revision to Diff 182531.Thu, Jul 23, 3:13 PM

Initialize error.

This revision now requires review to proceed.Thu, Jul 23, 3:13 PM
kib mentioned this in rG8f320c2bc473: getpgrp(2), getsid(2): allow to call on zombies.Thu, Jul 23, 11:51 PM
kib accepted this revision.Thu, Jul 23, 11:53 PM
This revision is now accepted and ready to land.Thu, Jul 23, 11:53 PM
kib closed this revision.Thu, Jul 23, 11:53 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
11 lines

Diff 182485

View Options

sys/kern/kern_prot.c

Loading...