Page MenuHomeFreeBSD
Differential D7169

Allwinner A64 support
ClosedPublic
Actions

Authored by jmcneill on Jul 10 2016, 1:23 AM.
Tags
Referenced Files
Unknown Object (File)
Sun, Mar 30, 11:04 AM
Unknown Object (File)
Sun, Mar 30, 7:58 AM
Unknown Object (File)
Fri, Mar 28, 11:18 AM
Unknown Object (File)
Sun, Mar 23, 6:16 PM
Unknown Object (File)
Sun, Mar 23, 12:02 PM
Unknown Object (File)
Mar 11 2025, 4:35 PM
Unknown Object (File)
Mar 10 2025, 4:13 PM
Unknown Object (File)
Mar 8 2025, 8:43 AM
View All Files
Subscribers
andrew
emaste
imp
loos
manu

Details

Reviewers
None
Group Reviewers
ARM
arm64
Commits
rS305134: Add Allwinner A64 (sun50i) and Pine64 dts files.
Summary

Initial support for Allwinner A64 SoC.

What's working:

  • MMC
  • GPIO / pinctrl
  • Clock controller
  • NMI intc
  • RSB
  • AXP803 PMIC
  • Ethernet
  • MMC
  • USB host controllers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jmcneill updated this revision to Diff 18246.Jul 10 2016, 1:23 AM
jmcneill retitled this revision from to Allwinner A64 support.
jmcneill updated this object.
jmcneill edited the test plan for this revision. (Show Details)
jmcneill added reviewers: arm64, ARM.
jmcneill set the repository for this revision to rS FreeBSD src repository - subversion.
jmcneill added projects: arm64, ARM.
Herald added subscribers: loos, emaste, andrew, imp. · View Herald TranscriptJul 10 2016, 1:23 AM
jmcneill added a parent revision: D6957: extres: add clk_get_by_ofw_node_index.Jul 10 2016, 1:32 AM
andrew added inline comments.Jul 10 2016, 8:15 AM
sys/arm/allwinner/a10_mmc.c
200

Can you make it #else /* __aarch64__ */ so it's documented what the else case if for.

sys/arm/allwinner/aw_rtc.c
67

#else /* __arm__ */

sys/arm/allwinner/aw_usbphy.c
44

Why is this needed?

183–184

Use %jd and cast phy to an intmax_t

sys/arm/allwinner/clk/aw_gate.c
140

Why not just return? There's no tear down in the failure case that a goto would simplify.

sys/arm64/conf/GENERIC
180–182

These shouldn't be added to GENERIC

sys/conf/files.arm64
95

This is already in sys/conf/files.

manu added a subscriber: manu.Jul 10 2016, 8:17 AM
manu added inline comments.
sys/arm/allwinner/a10_mmc.c
262

Maybe it would be better in a separate commit ?

323

Same thing for the DMA align

sys/arm/allwinner/a64/files.a64
1

Is this file used ?
Also maybe it need to go into sys/arm64 instead ?

manu added inline comments.Jul 10 2016, 8:21 AM
sys/arm/allwinner/aw_rtc.c
68

Also maybe update the RTC driver to have the year min/max stuff into softc so we don't rely on allwinner_soc_family would be better.

jmcneill added inline comments.Jul 10 2016, 10:18 AM
sys/arm/allwinner/a10_mmc.c
262

Agreed

323

Agreed

sys/arm/allwinner/a64/files.a64
1

I left it here because I thought we might want to support sun50i in the 32-bit ALLWINNER kernel some day. It doesn't matter to me if files.a64 stays or goes but I think sys/arm is the right place for these files.

sys/arm/allwinner/aw_rtc.c
68

I can remove the dependency on allwinner_soc_family easily but I think refactoring the driver is best left for a separate commit.

jmcneill updated this revision to Diff 18250.Jul 10 2016, 11:42 AM

Changes based on feedback from andrew and manu.

jmcneill marked 13 inline comments as done.Jul 10 2016, 11:44 AM
jmcneill updated this revision to Diff 18253.Jul 10 2016, 9:18 PM

Update for extres API changes in r302528

andrew added a comment.Jul 11 2016, 9:43 AM

I think the following files can just be committed:

a10_ehci.c
a10_gpio.c
a10_mmc.c
a64_padconf.c
a64_r_padconf.c
aw_ccu.c
aw_nmi.c
aw_rsb.c
aw_usbphy.c
options.arm64

sys/arm/allwinner/clk/aw_gate.c
200–204

Can you use ofw_bus_is_compatible here?

jmcneill updated this revision to Diff 18294.Jul 11 2016, 8:32 PM

Sync with head, some changes from the original diff have been committed.

jmcneill updated this revision to Diff 18295.Jul 11 2016, 8:35 PM

fdt_is_compatible -> ofw_bus_is_compatible

jmcneill marked an inline comment as done.Jul 11 2016, 8:36 PM
andrew added inline comments.Aug 6 2016, 7:02 PM
sys/arm/allwinner/clk/aw_gate.c
47

Is this needed?

sys/arm/allwinner/if_awg.c
82

What is the busdma issue?

sys/arm/allwinner/if_awgreg.h
181

What is the issue?

jmcneill updated this revision to Diff 19600.Aug 24 2016, 12:08 AM

Sync with head

manu added a comment.Aug 24 2016, 1:22 AM
sys/boot/efi/loader/main.c
414 ↗(On Diff #19600)

This shouldn't be commited with a64 changes.

sys/boot/fdt/dts/arm/a64.dtsi
128

This shouldn't be needed now.

andrew added a comment.Aug 24 2016, 11:21 AM

I think most of the .c and .h files are ready, other than if_awg*. I'm undecided on how to handle dts files for arm64 so hold off on adding them for now.

sys/conf/files.arm64
2–25

You should only use soc_allwinner_a64 for SoC specific attachments. For these you should create a new device name.

imp added a comment.Aug 24 2016, 1:46 PM
In D7169#158479, @andrew wrote:

I'm undecided on how to handle dts files for arm64 so hold off on adding them for now.

Can you talk more about this? We have a bit of a mess at the moment in arm land that's closely related to the u-boot mess that we have that I've started to clean up.

jmcneill updated this revision to Diff 19656.Aug 25 2016, 12:13 AM

Fixes based on feedback

jmcneill marked 2 inline comments as done.Aug 25 2016, 12:14 AM
jmcneill updated this revision to Diff 19673.Aug 25 2016, 1:27 PM

Sync with head, sort devices in GENERIC into device type sections.

jmcneill updated this object.Aug 25 2016, 1:27 PM
jmcneill updated this revision to Diff 19684.Aug 25 2016, 6:52 PM

Sync with head. Only sun50i/a64 and Pine64 .dts files remain.

jmcneill updated this revision to Diff 19696.Aug 25 2016, 10:41 PM

Add support for USB-EHCI0/USB-OHCI0 (bottom USB port on Pine64).

jmcneill updated this object.Aug 25 2016, 10:42 PM
jmcneill updated this revision to Diff 19702.Aug 25 2016, 11:56 PM

Support both USB host controllers on A64. The first host controller shares a PHY with the OTG controller, so we need to configure the PHY appropriately. Now both USB ports work on Pine64.

jmcneill updated this object.Aug 25 2016, 11:57 PM
jmcneill updated this revision to Diff 19749.Aug 27 2016, 12:19 PM

Use the A64 watchdog to reset the system; the psci reboot method doesn't seem to work.

jmcneill updated this revision to Diff 19840.Aug 30 2016, 11:19 AM

Sync with head

sys/arm/allwinner/aw_usbphy.c
80

Not all usbphy nodes have 3 resources, this needs to be modified to support other SoCs.

jmcneill updated this revision to Diff 19859.Aug 31 2016, 1:16 AM

Support between 2 and 4 USB PHY resources.

jmcneill updated this revision to Diff 19876.Aug 31 2016, 4:16 PM

Sync with head. The only changes remaining are the new dts files.

jmcneill updated this revision to Diff 19878.Aug 31 2016, 4:35 PM

Move dts files to boot/fdt/dts/arm64

jmcneill updated this revision to Diff 19879.Aug 31 2016, 4:45 PM

add Makefile for boot/fdt/dts/arm64

Closed by commit rS305134: Add Allwinner A64 (sun50i) and Pine64 dts files. (authored by jmcneill). · Explain WhyAug 31 2016, 4:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
arm/
allwinner/
3 lines
14 lines
3 lines
16 lines
a64/
160 lines
64 lines
4 lines
1 line
1 line
6 lines
4 lines
7 lines
184 lines
clk/
90 lines
41 lines
50 lines
205 lines
4 lines
arm64/
conf/
21 lines
boot/
fdt/
dts/
arm/
137 lines
81 lines
80 lines
71 lines
70 lines
659 lines
conf/
25 lines
1 line

Diff 18246

View Options

sys/arm/allwinner/a10_ehci.c

Show First 20 Lines • Show All 182 Lines • ▼ Show 20 Lines union {
} vop_args; } vop_args;
} args; } args;
}; };
static int vn_io_fault1(struct vnode *vp, struct uio *uio, static int vn_io_fault1(struct vnode *vp, struct uio *uio,
struct vn_io_fault_args *args, struct thread *td); struct vn_io_fault_args *args, struct thread *td);
int int
vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp) vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp)
kibUnsubmitted
Not Done
Inline Actions

Why do you need this?

For rw it was needed due to the vn_io_fault() structure, for vn_deallocate() it is pointless complication.

kib: Why do you need this? For rw it was needed due to the vn_io_fault() structure, for…
{ {
struct thread *td = ndp->ni_cnd.cn_thread; struct thread *td = ndp->ni_cnd.cn_thread;
return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp)); return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp));
} }
static uint64_t static uint64_t
open2nameif(int fmode, u_int vn_open_flags) open2nameif(int fmode, u_int vn_open_flags)
▲ Show 20 Lines • Show All 3,260 Lines • ▼ Show 20 Lines#endif
return (error); return (error);
} }
static int static int
vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags,
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
struct ucred *cred;
struct mount *mp; struct mount *mp;
void *rl_cookie; void *rl_cookie;
off_t off, len; off_t off, len;
int error; int error;
#ifdef AUDIT #ifdef AUDIT
bool audited_vnode1 = false; bool audited_vnode1 = false;
#endif #endif
Show All 27 Lines#ifdef AUDIT
} }
#endif #endif
#ifdef MAC #ifdef MAC
if ((ioflag & IO_NOMACCHECK) == 0) if ((ioflag & IO_NOMACCHECK) == 0)
error = mac_vnode_check_write(active_cred, file_cred, error = mac_vnode_check_write(active_cred, file_cred,
vp); vp);
#endif #endif
if (error == 0) if (error == 0) {
if (file_cred != NULL)
cred = file_cred;
else
cred = active_cred;
error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag, error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag,
active_cred); cred);
}
if ((ioflag & IO_NODELOCKED) == 0) { if ((ioflag & IO_NODELOCKED) == 0) {
VOP_UNLOCK(vp); VOP_UNLOCK(vp);
if (mp != NULL) { if (mp != NULL) {
vn_finished_write(mp); vn_finished_write(mp);
mp = NULL; mp = NULL;
} }
} }
if (error == 0 && len != 0) if (error == 0 && len != 0)
maybe_yield(); maybe_yield();
} }
out: out:
if (rl_cookie != NULL) if (rl_cookie != NULL)
vn_rangelock_unlock(vp, rl_cookie); vn_rangelock_unlock(vp, rl_cookie);
*offset = off; *offset = off;
*length = len; *length = len;
return (error); return (error);
} }
int int
vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags,
kibUnsubmitted
Not Done
Inline Actions

When I talked about commenting the use, I mean that it should explain that function is supposed to be used in the situations where the op is not triggered by a user request. In other words, currthread->td_ucred == active_cred is generally not the right credentials to account the operation to.

Your line above just repeats the code.

kib: When I talked about commenting the use, I mean that it should explain that function is supposed…
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset || if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset ||
flags != 0) flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
return (vn_deallocate_impl(vp, offset, length, flags, ioflag, return (vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, file_cred)); active_cred, file_cred));
} }
kibUnsubmitted
Done
Inline Actions

cred = file_cred != NOCRED ? file_cred : active_cred;

kib: `cred = file_cred != NOCRED ? file_cred : active_cred;`
static int static int
vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags, vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags,
struct ucred *active_cred, struct thread *td) struct ucred *active_cred, struct thread *td)
{ {
int error; int error;
struct vnode *vp; struct vnode *vp;
int ioflag; int ioflag;
vp = fp->f_vnode; vp = fp->f_vnode;
if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 || if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 ||
*length > OFF_MAX - *offset || flags != 0) *length > OFF_MAX - *offset || flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
ioflag = get_write_ioflag(fp); ioflag = get_write_ioflag(fp);
switch (cmd) { switch (cmd) {
case SPACECTL_DEALLOC: case SPACECTL_DEALLOC:
error = vn_deallocate_impl(vp, offset, length, flags, ioflag, error = vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, fp->f_cred); active_cred, fp->f_cred);
kibUnsubmitted
Not Done
Inline Actions

why passing fp->f_cred there at all?
from_fops is ugly and arguably not needed.
vn_deallocate() needs explanation about active_cre/file_cred in a comment, nobody would read man page for this (or in both)

kib: why passing fp->f_cred there at all? from_fops is ugly and arguably not needed. vn_deallocate()…
khngAuthorUnsubmitted
Not Done
Inline Actions

The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the policy modules in base so far are not taking f_cred into consideration at all).

khng: The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the…
khngAuthorUnsubmitted
Done
Inline Actions

A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base policy module, it is possibly used by outside world to implement capability semantic.

khng: A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base…
break; break;
default: default:
panic("vn_fspacectl: unknown cmd %d", cmd); panic("vn_fspacectl: unknown cmd %d", cmd);
} }
return (error); return (error);
} }
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines
View Options

sys/arm/allwinner/a10_gpio.c

Show First 20 Lines • Show All 182 Lines • ▼ Show 20 Lines union {
} vop_args; } vop_args;
} args; } args;
}; };
static int vn_io_fault1(struct vnode *vp, struct uio *uio, static int vn_io_fault1(struct vnode *vp, struct uio *uio,
struct vn_io_fault_args *args, struct thread *td); struct vn_io_fault_args *args, struct thread *td);
int int
vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp) vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp)
kibUnsubmitted
Not Done
Inline Actions

Why do you need this?

For rw it was needed due to the vn_io_fault() structure, for vn_deallocate() it is pointless complication.

kib: Why do you need this? For rw it was needed due to the vn_io_fault() structure, for…
{ {
struct thread *td = ndp->ni_cnd.cn_thread; struct thread *td = ndp->ni_cnd.cn_thread;
return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp)); return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp));
} }
static uint64_t static uint64_t
open2nameif(int fmode, u_int vn_open_flags) open2nameif(int fmode, u_int vn_open_flags)
▲ Show 20 Lines • Show All 3,260 Lines • ▼ Show 20 Lines#endif
return (error); return (error);
} }
static int static int
vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags,
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
struct ucred *cred;
struct mount *mp; struct mount *mp;
void *rl_cookie; void *rl_cookie;
off_t off, len; off_t off, len;
int error; int error;
#ifdef AUDIT #ifdef AUDIT
bool audited_vnode1 = false; bool audited_vnode1 = false;
#endif #endif
Show All 27 Lines#ifdef AUDIT
} }
#endif #endif
#ifdef MAC #ifdef MAC
if ((ioflag & IO_NOMACCHECK) == 0) if ((ioflag & IO_NOMACCHECK) == 0)
error = mac_vnode_check_write(active_cred, file_cred, error = mac_vnode_check_write(active_cred, file_cred,
vp); vp);
#endif #endif
if (error == 0) if (error == 0) {
if (file_cred != NULL)
cred = file_cred;
else
cred = active_cred;
error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag, error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag,
active_cred); cred);
}
if ((ioflag & IO_NODELOCKED) == 0) { if ((ioflag & IO_NODELOCKED) == 0) {
VOP_UNLOCK(vp); VOP_UNLOCK(vp);
if (mp != NULL) { if (mp != NULL) {
vn_finished_write(mp); vn_finished_write(mp);
mp = NULL; mp = NULL;
} }
} }
if (error == 0 && len != 0) if (error == 0 && len != 0)
maybe_yield(); maybe_yield();
} }
out: out:
if (rl_cookie != NULL) if (rl_cookie != NULL)
vn_rangelock_unlock(vp, rl_cookie); vn_rangelock_unlock(vp, rl_cookie);
*offset = off; *offset = off;
*length = len; *length = len;
return (error); return (error);
} }
int int
vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags,
kibUnsubmitted
Not Done
Inline Actions

When I talked about commenting the use, I mean that it should explain that function is supposed to be used in the situations where the op is not triggered by a user request. In other words, currthread->td_ucred == active_cred is generally not the right credentials to account the operation to.

Your line above just repeats the code.

kib: When I talked about commenting the use, I mean that it should explain that function is supposed…
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset || if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset ||
flags != 0) flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
return (vn_deallocate_impl(vp, offset, length, flags, ioflag, return (vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, file_cred)); active_cred, file_cred));
} }
kibUnsubmitted
Done
Inline Actions

cred = file_cred != NOCRED ? file_cred : active_cred;

kib: `cred = file_cred != NOCRED ? file_cred : active_cred;`
static int static int
vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags, vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags,
struct ucred *active_cred, struct thread *td) struct ucred *active_cred, struct thread *td)
{ {
int error; int error;
struct vnode *vp; struct vnode *vp;
int ioflag; int ioflag;
vp = fp->f_vnode; vp = fp->f_vnode;
if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 || if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 ||
*length > OFF_MAX - *offset || flags != 0) *length > OFF_MAX - *offset || flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
ioflag = get_write_ioflag(fp); ioflag = get_write_ioflag(fp);
switch (cmd) { switch (cmd) {
case SPACECTL_DEALLOC: case SPACECTL_DEALLOC:
error = vn_deallocate_impl(vp, offset, length, flags, ioflag, error = vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, fp->f_cred); active_cred, fp->f_cred);
kibUnsubmitted
Not Done
Inline Actions

why passing fp->f_cred there at all?
from_fops is ugly and arguably not needed.
vn_deallocate() needs explanation about active_cre/file_cred in a comment, nobody would read man page for this (or in both)

kib: why passing fp->f_cred there at all? from_fops is ugly and arguably not needed. vn_deallocate()…
khngAuthorUnsubmitted
Not Done
Inline Actions

The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the policy modules in base so far are not taking f_cred into consideration at all).

khng: The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the…
khngAuthorUnsubmitted
Done
Inline Actions

A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base policy module, it is possibly used by outside world to implement capability semantic.

khng: A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base…
break; break;
default: default:
panic("vn_fspacectl: unknown cmd %d", cmd); panic("vn_fspacectl: unknown cmd %d", cmd);
} }
return (error); return (error);
} }
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines
View Options

sys/arm/allwinner/a10_mmc.h

Show First 20 Lines • Show All 182 Lines • ▼ Show 20 Lines union {
} vop_args; } vop_args;
} args; } args;
}; };
static int vn_io_fault1(struct vnode *vp, struct uio *uio, static int vn_io_fault1(struct vnode *vp, struct uio *uio,
struct vn_io_fault_args *args, struct thread *td); struct vn_io_fault_args *args, struct thread *td);
int int
vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp) vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp)
kibUnsubmitted
Not Done
Inline Actions

Why do you need this?

For rw it was needed due to the vn_io_fault() structure, for vn_deallocate() it is pointless complication.

kib: Why do you need this? For rw it was needed due to the vn_io_fault() structure, for…
{ {
struct thread *td = ndp->ni_cnd.cn_thread; struct thread *td = ndp->ni_cnd.cn_thread;
return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp)); return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp));
} }
static uint64_t static uint64_t
open2nameif(int fmode, u_int vn_open_flags) open2nameif(int fmode, u_int vn_open_flags)
▲ Show 20 Lines • Show All 3,260 Lines • ▼ Show 20 Lines#endif
return (error); return (error);
} }
static int static int
vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags,
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
struct ucred *cred;
struct mount *mp; struct mount *mp;
void *rl_cookie; void *rl_cookie;
off_t off, len; off_t off, len;
int error; int error;
#ifdef AUDIT #ifdef AUDIT
bool audited_vnode1 = false; bool audited_vnode1 = false;
#endif #endif
Show All 27 Lines#ifdef AUDIT
} }
#endif #endif
#ifdef MAC #ifdef MAC
if ((ioflag & IO_NOMACCHECK) == 0) if ((ioflag & IO_NOMACCHECK) == 0)
error = mac_vnode_check_write(active_cred, file_cred, error = mac_vnode_check_write(active_cred, file_cred,
vp); vp);
#endif #endif
if (error == 0) if (error == 0) {
if (file_cred != NULL)
cred = file_cred;
else
cred = active_cred;
error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag, error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag,
active_cred); cred);
}
if ((ioflag & IO_NODELOCKED) == 0) { if ((ioflag & IO_NODELOCKED) == 0) {
VOP_UNLOCK(vp); VOP_UNLOCK(vp);
if (mp != NULL) { if (mp != NULL) {
vn_finished_write(mp); vn_finished_write(mp);
mp = NULL; mp = NULL;
} }
} }
if (error == 0 && len != 0) if (error == 0 && len != 0)
maybe_yield(); maybe_yield();
} }
out: out:
if (rl_cookie != NULL) if (rl_cookie != NULL)
vn_rangelock_unlock(vp, rl_cookie); vn_rangelock_unlock(vp, rl_cookie);
*offset = off; *offset = off;
*length = len; *length = len;
return (error); return (error);
} }
int int
vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags,
kibUnsubmitted
Not Done
Inline Actions

When I talked about commenting the use, I mean that it should explain that function is supposed to be used in the situations where the op is not triggered by a user request. In other words, currthread->td_ucred == active_cred is generally not the right credentials to account the operation to.

Your line above just repeats the code.

kib: When I talked about commenting the use, I mean that it should explain that function is supposed…
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset || if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset ||
flags != 0) flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
return (vn_deallocate_impl(vp, offset, length, flags, ioflag, return (vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, file_cred)); active_cred, file_cred));
} }
kibUnsubmitted
Done
Inline Actions

cred = file_cred != NOCRED ? file_cred : active_cred;

kib: `cred = file_cred != NOCRED ? file_cred : active_cred;`
static int static int
vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags, vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags,
struct ucred *active_cred, struct thread *td) struct ucred *active_cred, struct thread *td)
{ {
int error; int error;
struct vnode *vp; struct vnode *vp;
int ioflag; int ioflag;
vp = fp->f_vnode; vp = fp->f_vnode;
if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 || if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 ||
*length > OFF_MAX - *offset || flags != 0) *length > OFF_MAX - *offset || flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
ioflag = get_write_ioflag(fp); ioflag = get_write_ioflag(fp);
switch (cmd) { switch (cmd) {
case SPACECTL_DEALLOC: case SPACECTL_DEALLOC:
error = vn_deallocate_impl(vp, offset, length, flags, ioflag, error = vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, fp->f_cred); active_cred, fp->f_cred);
kibUnsubmitted
Not Done
Inline Actions

why passing fp->f_cred there at all?
from_fops is ugly and arguably not needed.
vn_deallocate() needs explanation about active_cre/file_cred in a comment, nobody would read man page for this (or in both)

kib: why passing fp->f_cred there at all? from_fops is ugly and arguably not needed. vn_deallocate()…
khngAuthorUnsubmitted
Not Done
Inline Actions

The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the policy modules in base so far are not taking f_cred into consideration at all).

khng: The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the…
khngAuthorUnsubmitted
Done
Inline Actions

A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base policy module, it is possibly used by outside world to implement capability semantic.

khng: A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base…
break; break;
default: default:
panic("vn_fspacectl: unknown cmd %d", cmd); panic("vn_fspacectl: unknown cmd %d", cmd);
} }
return (error); return (error);
} }
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines
View Options

sys/arm/allwinner/a10_mmc.c

Show First 20 Lines • Show All 182 Lines • ▼ Show 20 Lines union {
} vop_args; } vop_args;
} args; } args;
}; };
static int vn_io_fault1(struct vnode *vp, struct uio *uio, static int vn_io_fault1(struct vnode *vp, struct uio *uio,
struct vn_io_fault_args *args, struct thread *td); struct vn_io_fault_args *args, struct thread *td);
int int
vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp) vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp)
kibUnsubmitted
Not Done
Inline Actions

Why do you need this?

For rw it was needed due to the vn_io_fault() structure, for vn_deallocate() it is pointless complication.

kib: Why do you need this? For rw it was needed due to the vn_io_fault() structure, for…
{ {
struct thread *td = ndp->ni_cnd.cn_thread; struct thread *td = ndp->ni_cnd.cn_thread;
return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp)); return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp));
} }
static uint64_t static uint64_t
open2nameif(int fmode, u_int vn_open_flags) open2nameif(int fmode, u_int vn_open_flags)
▲ Show 20 Lines • Show All 3,260 Lines • ▼ Show 20 Lines#endif
return (error); return (error);
} }
static int static int
vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags,
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
struct ucred *cred;
struct mount *mp; struct mount *mp;
void *rl_cookie; void *rl_cookie;
off_t off, len; off_t off, len;
int error; int error;
#ifdef AUDIT #ifdef AUDIT
bool audited_vnode1 = false; bool audited_vnode1 = false;
#endif #endif
Show All 27 Lines#ifdef AUDIT
} }
#endif #endif
#ifdef MAC #ifdef MAC
if ((ioflag & IO_NOMACCHECK) == 0) if ((ioflag & IO_NOMACCHECK) == 0)
error = mac_vnode_check_write(active_cred, file_cred, error = mac_vnode_check_write(active_cred, file_cred,
vp); vp);
#endif #endif
if (error == 0) if (error == 0) {
if (file_cred != NULL)
cred = file_cred;
else
cred = active_cred;
error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag, error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag,
active_cred); cred);
}
if ((ioflag & IO_NODELOCKED) == 0) { if ((ioflag & IO_NODELOCKED) == 0) {
VOP_UNLOCK(vp); VOP_UNLOCK(vp);
if (mp != NULL) { if (mp != NULL) {
vn_finished_write(mp); vn_finished_write(mp);
mp = NULL; mp = NULL;
} }
} }
if (error == 0 && len != 0) if (error == 0 && len != 0)
maybe_yield(); maybe_yield();
} }
out: out:
if (rl_cookie != NULL) if (rl_cookie != NULL)
vn_rangelock_unlock(vp, rl_cookie); vn_rangelock_unlock(vp, rl_cookie);
*offset = off; *offset = off;
*length = len; *length = len;
return (error); return (error);
} }
int int
vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags,
kibUnsubmitted
Not Done
Inline Actions

When I talked about commenting the use, I mean that it should explain that function is supposed to be used in the situations where the op is not triggered by a user request. In other words, currthread->td_ucred == active_cred is generally not the right credentials to account the operation to.

Your line above just repeats the code.

kib: When I talked about commenting the use, I mean that it should explain that function is supposed…
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset || if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset ||
flags != 0) flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
return (vn_deallocate_impl(vp, offset, length, flags, ioflag, return (vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, file_cred)); active_cred, file_cred));
} }
kibUnsubmitted
Done
Inline Actions

cred = file_cred != NOCRED ? file_cred : active_cred;

kib: `cred = file_cred != NOCRED ? file_cred : active_cred;`
static int static int
vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags, vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags,
struct ucred *active_cred, struct thread *td) struct ucred *active_cred, struct thread *td)
{ {
int error; int error;
struct vnode *vp; struct vnode *vp;
int ioflag; int ioflag;
vp = fp->f_vnode; vp = fp->f_vnode;
if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 || if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 ||
*length > OFF_MAX - *offset || flags != 0) *length > OFF_MAX - *offset || flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
ioflag = get_write_ioflag(fp); ioflag = get_write_ioflag(fp);
switch (cmd) { switch (cmd) {
case SPACECTL_DEALLOC: case SPACECTL_DEALLOC:
error = vn_deallocate_impl(vp, offset, length, flags, ioflag, error = vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, fp->f_cred); active_cred, fp->f_cred);
kibUnsubmitted
Not Done
Inline Actions

why passing fp->f_cred there at all?
from_fops is ugly and arguably not needed.
vn_deallocate() needs explanation about active_cre/file_cred in a comment, nobody would read man page for this (or in both)

kib: why passing fp->f_cred there at all? from_fops is ugly and arguably not needed. vn_deallocate()…
khngAuthorUnsubmitted
Not Done
Inline Actions

The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the policy modules in base so far are not taking f_cred into consideration at all).

khng: The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the…
khngAuthorUnsubmitted
Done
Inline Actions

A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base policy module, it is possibly used by outside world to implement capability semantic.

khng: A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base…
break; break;
default: default:
panic("vn_fspacectl: unknown cmd %d", cmd); panic("vn_fspacectl: unknown cmd %d", cmd);
} }
return (error); return (error);
} }
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines
View Options

sys/arm/allwinner/a64/a64_padconf.c

Loading...
View Options

sys/arm/allwinner/a64/a64_r_padconf.c

Loading...
View Options

sys/arm/allwinner/a64/files.a64

Loading...
View Options

sys/arm/allwinner/aw_ccu.c

Loading...
View Options

sys/arm/allwinner/aw_nmi.c

Loading...
View Options

sys/arm/allwinner/aw_rsb.c

Loading...
View Options

sys/arm/allwinner/aw_rtc.c

Loading...
View Options

sys/arm/allwinner/aw_usbphy.c

Loading...
View Options

sys/arm/allwinner/axp81x.c

Loading...
View Options

sys/arm/allwinner/clk/aw_gate.c

Loading...
View Options

sys/arm/allwinner/clk/aw_modclk.c

Loading...
View Options

sys/arm/allwinner/clk/aw_pll.c

Loading...
View Options

sys/arm/allwinner/if_awg.c

Loading...
View Options

sys/arm/allwinner/if_awgreg.h

Loading...
View Options

sys/arm64/conf/GENERIC

Loading...
View Options

sys/boot/fdt/dts/arm/a64.dtsi

Loading...
View Options

sys/boot/fdt/dts/arm/pine64_plus.dts

Loading...
View Options

sys/boot/fdt/dts/arm/sun50i-a64-pine64-common.dtsi

Loading...
View Options

sys/boot/fdt/dts/arm/sun50i-a64-pine64-plus.dts

Loading...
View Options

sys/boot/fdt/dts/arm/sun50i-a64-pine64.dts

Loading...
View Options

sys/boot/fdt/dts/arm/sun50i-a64.dtsi

Loading...
View Options

sys/conf/files.arm64

Loading...
View Options

sys/conf/options.arm64

Loading...