nvme: Add quirk for broken namespace-change log
Needs ReviewPublic
Actions

Authored by cperciva on Tue, Jul 14, 6:50 PM.

Details

Reviewers

Summary

Add a QUIRK_EMPTY_NAMESPACE_CHANGED_LOG quirk which indicates that the
nvme controller may not properly populate the namespace-changed log
page. If we receive a NVME_LOG_CHANGED_NAMESPACE page for a device
with this quirk and the page is empty, probe all of the namespaces
rather than none of them.

MFC after: 1 week
Sponsored by: Amazon

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74801
Build 71684: arc lint + arc unit

Event Timeline

cperciva created this revision.Tue, Jul 14, 6:50 PM

Herald added a subscriber: dab. · View Herald TranscriptTue, Jul 14, 6:50 PM

cperciva requested review of this revision.Tue, Jul 14, 6:50 PM

Harbormaster completed remote builds in B74801: Diff 181988.Tue, Jul 14, 6:50 PM

cperciva added a parent revision: D58230: nda: Don't sleep with non-sleepable lock held.Tue, Jul 14, 6:50 PM

cperciva added a child revision: D58232: nvme: Add quirk for Amazon EBS NVMe Controller.

cperciva added inline comments.Tue, Jul 14, 7:00 PM

sys/dev/nvme/nvme_ctrlr.c
1312	@imp I followed the pattern of what you wrote earlier, in terms of notifying every child about each (potentially) changed namespace, but I have to admit that I don't understand under what conditions we would have multiple children or whether it would make sense that all of them need to be notified about all of the changed namespaces.