exterr: allow exterr to fit pointers on CHERI targets
ClosedPublic
Actions

Authored by brooks on Mon, Jul 6, 4:05 PM.

Details

Reviewers

kib
mckusick

Group Reviewers

cheri

Commits

rG844009378da9: exterr: allow exterr to fit pointers on CHERI targets

Summary

Switch to uint64ptr_t which is a uint64_t on traditional architectures
and a uintptr_t on CHERI architectures. This has no ABI impact on
non-CHERI kernels.

Fix truncation of 64-bit values on 32-bit kernels.

Effort: CHERI upstreaming
Sponsored by: Innovate UK

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 74549
Build 71432: arc lint + arc unit

Event Timeline

brooks created this revision.Mon, Jul 6, 4:05 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jul 6, 4:05 PM

brooks requested review of this revision.Mon, Jul 6, 4:05 PM

Herald added a reviewer: cheri. · View Herald TranscriptMon, Jul 6, 4:05 PM

Harbormaster completed remote builds in B74549: Diff 181369.Mon, Jul 6, 4:05 PM

brooks added a parent revision: D58055: exterrctl(2): add kern_exterrctl.Mon, Jul 6, 4:05 PM

brooks added a child revision: D58057: exterr: clear tags from arguments on CHERI targets.

brooks added inline comments.Mon, Jul 6, 4:13 PM

sys/sys/_uexterror.h
25	Probably these should also be `__uint64ptr_t`. On CHERI there's also an 8-byte gap above p1 which should maybe be explicit.
sys/sys/exterrvar.h
62	This was truncating 64-bit values on 32-bit kernels.