Paths

Table of Contentst

sack_filter: sack_filter_reject underflow guard
Needs ReviewPublic
Actions

Authored by thebugfixers_pm.me on Wed, Jun 24, 11:08 AM.

Tags

None

Referenced Files

	F161911674: D57814.id180522.diff
	Tue, Jul 7, 11:14 PM

	F161907242: D57814.diff
	Tue, Jul 7, 10:17 PM

	Unknown Object (File)
	Tue, Jul 7, 4:34 PM

	Unknown Object (File)
	Sun, Jul 5, 8:44 PM

	Unknown Object (File)
	Sun, Jul 5, 8:40 PM

	Unknown Object (File)
	Sun, Jul 5, 5:58 PM

	Unknown Object (File)
	Sun, Jul 5, 5:39 PM

	Unknown Object (File)
	Sun, Jul 5, 5:35 PM

Subscribers

Details

Reviewers

tuexen

Group Reviewers

Src Committers
Contributor Reviews (src)
transport

Summary

If two board entries share the same .end or .start the loop clears both bits and decrements sf_used twice.
Protect by using MPASS(sf->sf_used > 0); in front of the decrement.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

thebugfixers_pm.me created this revision.Wed, Jun 24, 11:08 AM

Herald added a reviewer: transport. · View Herald TranscriptWed, Jun 24, 11:08 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

thebugfixers_pm.me requested review of this revision.Wed, Jun 24, 11:08 AM

thebugfixers_pm.me added a parent revision: D57813: sack_filter: Brand-new path in sack_filter_blks.Fri, Jun 26, 5:25 PM

I think this patch would just hide bugs related to the accounting done using sf_used. There are four occurrences of sf->sf_used--. You might want to protect all of them by adding MPASS(sf->sf_used > 0); in front of the decrement.

tuexen requested changes to this revision.Sun, Jun 28, 12:03 PM

tuexen added a reviewer: tuexen.

This revision now requires changes to proceed.Sun, Jun 28, 12:03 PM

Thanks for the review. Fair point. Revised diff and summary accordingly.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

sack_filter.c

7 lines

Diff 180878

View Options

sys/netinet/tcp_stacks/sack_filter.c

sack_filter: sack_filter_reject underflow guardNeeds ReviewPublicActions