Paths

Table of Contentst

sack_filter: guard against unsigned underflow (tcp_fixed_maxseg)
AbandonedPublic
Actions

Authored by thebugfixers_pm.me on Wed, Jun 24, 11:14 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jul 16, 4:19 AM

	Unknown Object (File)
	Sun, Jul 5, 9:13 PM

	Unknown Object (File)
	Sun, Jul 5, 8:27 PM

	Unknown Object (File)
	Sun, Jul 5, 8:24 PM

	Unknown Object (File)
	Sun, Jul 5, 2:55 AM

	Unknown Object (File)
	Sat, Jul 4, 3:56 AM

	Unknown Object (File)
	Fri, Jul 3, 9:03 PM

	Unknown Object (File)
	Fri, Jul 3, 9:01 PM

Subscribers

Details

Reviewers

tuexen

Group Reviewers

Src Committers
Contributor Reviews (src)
transport

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

thebugfixers_pm.me created this revision.Wed, Jun 24, 11:14 AM

Herald added a reviewer: transport. · View Herald TranscriptWed, Jun 24, 11:14 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

thebugfixers_pm.me requested review of this revision.Wed, Jun 24, 11:14 AM

thebugfixers_pm.me added a parent revision: D57813: sack_filter: Brand-new path in sack_filter_blks.Fri, Jun 26, 5:25 PM

tuexen requested changes to this revision.Sun, Jun 28, 12:06 PM

tuexen added a reviewer: tuexen.

This revision now requires changes to proceed.Sun, Jun 28, 12:06 PM

tcp_fixed_maxseg() is only used when to code is compiled for being tested in userland. So it might make more sense to add a check when processing the -S option to ensure that the value provided is at least 12. But again, this has no impact for the code being used inside the kernel.

thebugfixers_pm.me abandoned this revision.Sun, Jun 28, 3:32 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

sack_filter.c

2 lines

Diff 180523

View Options

sys/netinet/tcp_stacks/sack_filter.c

sack_filter: guard against unsigned underflow (tcp_fixed_maxseg)AbandonedPublicActions