Page MenuHomeFreeBSD

libfetch: Overhaul socket read / write
ClosedPublic

Authored by des on Jun 27 2026, 2:30 PM.
Tags
None
Referenced Files
F167948037: D57906.id180822.diff
Tue, Aug 25, 2:06 PM
Unknown Object (File)
Tue, Aug 25, 1:58 AM
Unknown Object (File)
Mon, Aug 24, 4:28 AM
Unknown Object (File)
Sun, Aug 23, 6:47 AM
Unknown Object (File)
Sun, Aug 23, 12:42 AM
Unknown Object (File)
Sat, Aug 22, 6:40 AM
Unknown Object (File)
Fri, Aug 21, 7:56 PM
Unknown Object (File)
Wed, Aug 19, 12:55 PM
Subscribers

Details

Summary
  • Make fetch_ssl_read() and fetch_ssl_write() behave more like read(2) and write(2), and drop fetch_socket_read() in favor of read(2).
  • Don't request POLLERR, it's implied.
  • Don't needlessly set errno, it's relatively costly.
  • Always check for EAGAIN from writev(2), otherwise we will abort on a short write instead of proceeding to poll(2).
  • Always check for EAGAIN from poll(2) even though it can't happen on FreeBSD; POSIX says it can, and it might in the future.
  • Rewrite fetch_read() and fetch_writev() to be more similar to each other. The main difference is that a partial read is treated as success while a partial write is treated as failure.

PR: 296316
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74329
Build 71212: arc lint + arc unit

Event Timeline

des requested review of this revision.Jun 27 2026, 2:30 PM
des edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jul 8 2026, 10:49 AM
This revision was automatically updated to reflect the committed changes.