Page MenuHomeFreeBSD

libfetch: Overhaul socket read / write
ClosedPublic

Authored by des on Sat, Jun 27, 2:30 PM.
Tags
None
Referenced Files
F163674368: D57906.diff
Sat, Jul 25, 8:58 AM
Unknown Object (File)
Fri, Jul 24, 3:56 PM
Unknown Object (File)
Fri, Jul 24, 9:53 AM
Unknown Object (File)
Fri, Jul 24, 12:44 AM
Unknown Object (File)
Thu, Jul 23, 7:43 PM
Unknown Object (File)
Thu, Jul 23, 7:30 PM
Unknown Object (File)
Thu, Jul 23, 8:35 AM
Unknown Object (File)
Thu, Jul 23, 4:13 AM
Subscribers

Details

Summary
  • Make fetch_ssl_read() and fetch_ssl_write() behave more like read(2) and write(2), and drop fetch_socket_read() in favor of read(2).
  • Don't request POLLERR, it's implied.
  • Don't needlessly set errno, it's relatively costly.
  • Always check for EAGAIN from writev(2), otherwise we will abort on a short write instead of proceeding to poll(2).
  • Always check for EAGAIN from poll(2) even though it can't happen on FreeBSD; POSIX says it can, and it might in the future.
  • Rewrite fetch_read() and fetch_writev() to be more similar to each other. The main difference is that a partial read is treated as success while a partial write is treated as failure.

PR: 296316
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74327
Build 71210: arc lint + arc unit

Event Timeline

des requested review of this revision.Sat, Jun 27, 2:30 PM
des edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Wed, Jul 8, 10:49 AM
This revision was automatically updated to reflect the committed changes.