sys/systm.h: use __nodiscard consistently and correctly
ClosedPublic
Actions

Authored by brooks on Fri, Jun 26, 12:16 PM.

Details

Reviewers

ivy
imp
markj
emaste

Commits

rGb207b1562a2f: sys/systm.h: use __nodiscard consistently and correctly

Summary

nodiscard is closer to (and sometimes expands to) nodiscard from
C23 and C++17 so prefer it to the homegrown result_use_check and put
it in the right place so it is correct when expanded to nodiscard.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 74293
Build 71176: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Fri, Jun 26, 12:16 PM

brooks created this revision.

Harbormaster completed remote builds in B74293: Diff 180703.Fri, Jun 26, 12:16 PM

brooks added a parent revision: D57881: cdefs(9): encourage __nodiscard over __result_use_check.Fri, Jun 26, 12:16 PM

brooks added a child revision: D57664: CHERI: declare fueptr and suptr.Fri, Jun 26, 12:18 PM

brooks added a child revision: D57663: CHERI: declare copy{in,out}ptr{,_nofault}.Fri, Jun 26, 12:58 PM

Thanks.

This revision is now accepted and ready to land.Fri, Jun 26, 1:46 PM

emaste accepted this revision.Fri, Jun 26, 2:40 PM

Closed by commit rGb207b1562a2f: sys/systm.h: use __nodiscard consistently and correctly (authored by brooks). · Explain WhyFri, Jun 26, 4:48 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGb207b1562a2f: sys/systm.h: use __nodiscard consistently and correctly.

Revision Contents
Changeset List

Path

Size

sys/

systm.h

12 lines

Diff 180703

View Options

sys/systm.h: use __nodiscard consistently and correctlyClosedPublicActions