Page MenuHomeFreeBSD

asmc: deduplicate sensor converters and cause sysctls
ClosedPublic

Authored by seuros on Jun 25 2026, 9:57 PM.
Referenced Files
F167963367: D57854.diff
Tue, Aug 25, 3:51 PM
F167957535: D57854.id180841.diff
Tue, Aug 25, 3:17 PM
F167938180: D57854.id180651.diff
Tue, Aug 25, 12:50 PM
F167922497: D57854.id181131.diff
Tue, Aug 25, 11:00 AM
F167857118: D57854.id.diff
Tue, Aug 25, 1:15 AM
Unknown Object (File)
Sun, Aug 23, 1:57 AM
Unknown Object (File)
Sat, Aug 22, 10:51 PM
Unknown Object (File)
Sat, Aug 22, 9:25 AM
Subscribers

Details

Summary

Replace per-type spXX_to_milli() functions with a table-driven
asmc_sensor_convert() that looks up the divisor by SMC type string.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74268
Build 71151: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jun 26 2026, 10:39 PM
This revision now requires review to proceed.Jun 27 2026, 10:38 PM
adrian added inline comments.
sys/dev/asmc/asmc.c
2608

oh interesting, is this handling key differences between sleep and non-sleep stuff? what did the old code do? Just assume MSSP always, right?

This revision is now accepted and ready to land.Jun 27 2026, 11:39 PM
seuros added inline comments.
sys/dev/asmc/asmc.c
2608

The old code had two separate handlers each hardcoded to its own key and is_sleep flag.

The diff merged them into one handler using arg2 as params.

No new logic was introduced in this diff.

This revision was automatically updated to reflect the committed changes.