link_elf: elf_set_add assertion accepts partial overlaps
Needs ReviewPublic
Actions

Authored by thebugfixers_pm.me on Wed, Jun 24, 7:04 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jul 8, 6:00 AM

	Unknown Object (File)
	Sun, Jul 5, 10:53 AM

	Unknown Object (File)
	Sat, Jul 4, 8:12 AM

	Unknown Object (File)
	Fri, Jul 3, 9:39 PM

	Unknown Object (File)
	Fri, Jul 3, 8:51 PM

	Unknown Object (File)
	Wed, Jul 1, 2:17 AM

	Unknown Object (File)
	Tue, Jun 30, 8:13 PM

	Unknown Object (File)
	Sat, Jun 27, 11:55 AM

View All 11 Files

Subscribers

imp

olce

Details

Reviewers

None

Group Reviewers

Src Committers
Contributor Reviews (src)

Summary

As presently constructed the condition appears to accept partial overlaps.
If the intent is non‑overlapping interval then there is potentially a bug in the assertion check logic here.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

thebugfixers_pm.me created this revision.Wed, Jun 24, 7:04 AM

Herald added subscribers: olce, imp. · View Herald TranscriptWed, Jun 24, 7:04 AM

thebugfixers_pm.me requested review of this revision.Wed, Jun 24, 7:04 AM

thebugfixers_pm.me added a parent revision: D57785: link_elf: Guard against subtraction underflow.Fri, Jun 26, 5:25 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

link_elf.c

3 lines

Diff 180509

View Options

link_elf: elf_set_add assertion accepts partial overlapsNeeds ReviewPublicActions