Linux ARM 5/16
AbandonedPublic
Actions

Authored by soutade_gmail.com on Jun 8 2016, 2:46 PM.

Details

Reviewers

gonzo
manu
dchagin
cognet
andrew

Summary

Linux ARM : Add linux_support.s that contains futex implementation

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

soutade_gmail.com updated this revision to Diff 17409.Jun 8 2016, 2:46 PM

soutade_gmail.com retitled this revision from to Linux ARM 5/16.

soutade_gmail.com updated this object.

soutade_gmail.com edited the test plan for this revision. (Show Details)

soutade_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.

soutade_gmail.com added projects: ARM, Linux Emulation.

Herald added subscribers: Contributor Reviews (src), andrew, imp. · View Herald TranscriptJun 8 2016, 2:46 PM

It looks like these should all be atomic operations. If so the flow should be:

1: ldrex old, [addr]
   operation
   strex res, new, [addr]
   cmp res, #0
   bne 1b

In D6762#142437, @andrew wrote:
It looks like these should all be atomic operations. If so the flow should be:
1: ldrex old, [addr]
   operation
   strex res, new, [addr]
   cmp res, #0
   bne 1b

Don't understand what is exactly the problem you point to.

bapt added reviewers: andrew, manu, cognet, dchagin, gonzo.Jun 27 2016, 10:47 PM

andrew added inline comments.Jun 27 2016, 11:24 PM

sys/arm/linux/linux_support.s
84	There is a `ldrex` here, but no `strex`. These should be in pairs with the needed operation between the two. See `sys/arm/include/atomic-v6.h` as an example.

Rework all functions with right use of ldrex and strex

Overtaken by D7970 .. D7978

Revision Contents
Changeset List

Path

Size

sys/

arm/

linux/

linux_support.s

115 lines

Diff 18043

View Options

sys/arm/linux/linux_support.s

Linux ARM 5/16AbandonedPublicActions