tests: Fix race condition in aslr_setuid
ClosedPublic
Actions

Authored by des on Jun 22 2026, 9:19 AM.

Details

Reviewers

Group Reviewers

Commits

rG8adf49dac1a9: tests: Fix race condition in aslr_setuid
rG19a496794685: tests: Fix race condition in aslr_setuid
rG080a4087014e: tests: Fix race condition in aslr_setuid

Summary

Use a cloexec pipe to block the parent until the child is ready.

While here, redirect the output from ping to /dev/null, and mark the
test as requiring the inet feature since we ping the IPv4 loopback.

PR: 296116
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Jun 22 2026, 9:19 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 22 2026, 9:19 AM

des requested review of this revision.Jun 22 2026, 9:19 AM

Harbormaster completed remote builds in B74094: Diff 180271.Jun 22 2026, 9:19 AM

Thanks.

Have you ever tried to run the test suite without an INET stack?

This revision is now accepted and ready to land.Jun 22 2026, 12:33 PM

In D57734#1323774, @markj wrote:

Have you ever tried to run the test suite without an INET stack?

Bits and pieces. Never the whole thing.

Closed by commit rG080a4087014e: tests: Fix race condition in aslr_setuid (authored by des). · Explain WhyJun 22 2026, 1:26 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG080a4087014e: tests: Fix race condition in aslr_setuid.

des added a commit: rG19a496794685: tests: Fix race condition in aslr_setuid.Jul 7 2026, 8:58 PM

des added a commit: rG8adf49dac1a9: tests: Fix race condition in aslr_setuid.

Revision Contents
Changeset List

Path

Size

tests/

sys/

kern/

Makefile

1 line

aslr.c

16 lines

Diff 180283

View Options

tests/sys/kern/Makefile