Page MenuHomeFreeBSD
Differential D57734

tests: Fix race condition in aslr_setuid
ClosedPublic
Actions

Authored by des on Mon, Jun 22, 9:19 AM.
Tags
None
Referenced Files
F162703033: D57734.diff
Wed, Jul 15, 11:12 PM
Unknown Object (File)
Wed, Jul 15, 7:27 AM
Unknown Object (File)
Wed, Jul 15, 7:27 AM
Unknown Object (File)
Tue, Jul 14, 11:34 PM
Unknown Object (File)
Tue, Jul 14, 12:53 PM
Unknown Object (File)
Tue, Jul 14, 1:33 AM
Unknown Object (File)
Mon, Jul 13, 4:14 PM
Unknown Object (File)
Sun, Jul 12, 5:34 PM
View All 28 Files
Subscribers
imp

Details

Reviewers
markj
Group Reviewers
tests
Commits
rG8adf49dac1a9: tests: Fix race condition in aslr_setuid
rG19a496794685: tests: Fix race condition in aslr_setuid
rG080a4087014e: tests: Fix race condition in aslr_setuid
Summary

Use a cloexec pipe to block the parent until the child is ready.

While here, redirect the output from ping to /dev/null, and mark the
test as requiring the inet feature since we ping the IPv4 loopback.

PR: 296116
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Mon, Jun 22, 9:19 AM
Herald added a subscriber: imp. · View Herald TranscriptMon, Jun 22, 9:19 AM
des requested review of this revision.Mon, Jun 22, 9:19 AM
Harbormaster completed remote builds in B74094: Diff 180271.Mon, Jun 22, 9:19 AM
markj accepted this revision.Mon, Jun 22, 12:33 PM

Thanks.

Have you ever tried to run the test suite without an INET stack?

This revision is now accepted and ready to land.Mon, Jun 22, 12:33 PM
des added a comment.Mon, Jun 22, 1:22 PM
In D57734#1323774, @markj wrote:

Have you ever tried to run the test suite without an INET stack?

Bits and pieces. Never the whole thing.

Closed by commit rG080a4087014e: tests: Fix race condition in aslr_setuid (authored by des). · Explain WhyMon, Jun 22, 1:26 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG080a4087014e: tests: Fix race condition in aslr_setuid.
des added a commit: rG19a496794685: tests: Fix race condition in aslr_setuid.Tue, Jul 7, 8:58 PM
des added a commit: rG8adf49dac1a9: tests: Fix race condition in aslr_setuid.

Revision Contents
Changeset List

PathSize
tests/
sys/
kern/
1 line
16 lines

Diff 180283

View Options

tests/sys/kern/Makefile

Loading...
View Options

tests/sys/kern/aslr.c

Loading...