Also, unlink our temporary file if we fail to chmod it.
MFC after: 1 week
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 73355 Build 70238: arc lint + arc unit
Event Timeline
| usr.sbin/lpr/lpd/printjob.c | ||
|---|---|---|
| 208 | The first sentence isn't necessarily true. I don't think it matters much though. | |
| usr.sbin/lpr/lpd/printjob.c | ||
|---|---|---|
| 208 | Barring a race condition, I think it's pretty much the only way we can get to this point with a non-zero statok, isn't it? Although perhaps we should make the fstat() unconditional and error out if it fails; just moving it into the condition for the if above should do the trick. | |
| usr.sbin/lpr/lpd/printjob.c | ||
|---|---|---|
| 208 | Yes, I was thinking of a race condition. I think checking after open() would be simpler. | |