Differential D6942

Use correct flag when cleaning up pfsync state
ClosedPublic
Actions

Authored by bz on Jun 23 2016, 4:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 22, 12:28 PM

	Unknown Object (File)
	Mon, Jun 22, 12:27 PM

	Unknown Object (File)
	Mon, Jun 22, 8:01 AM

	Unknown Object (File)
	Fri, Jun 12, 1:55 PM

	Unknown Object (File)
	May 22 2026, 12:36 AM

	Unknown Object (File)
	May 7 2026, 5:09 AM

	Unknown Object (File)
	May 2 2026, 11:09 AM

	Unknown Object (File)
	Apr 29 2026, 5:35 AM

Subscribers

Details

Reviewers

kp
gnn

Commits

rS302157: PFSTATE_NOSYNC goes onto state_flags, not sync_state;
rS302143: PFSTATE_NOSYNC goes onto state_flags, not sync_state;

Summary

PFSTATE_NOSYNC goes onto state_flags, not sync_state;
This prevents: panic: pfsync_delete_state: unexpected sync state 8

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bz updated this revision to Diff 17819.Jun 23 2016, 4:32 PM

bz retitled this revision from to Use correct flag when cleaning up pfsync state.

bz updated this object.

bz edited the test plan for this revision. (Show Details)

bz added reviewers: gnn, kp.

bz set the repository for this revision to rS FreeBSD src repository - subversion.

bz added a subscriber: network.

Herald added a subscriber: imp. · View Herald TranscriptJun 23 2016, 4:32 PM

Just add more context

Closed by commit rS302143: PFSTATE_NOSYNC goes onto state_flags, not sync_state; (authored by bz). · Explain WhyJun 23 2016, 4:36 PM

This revision was automatically updated to reflect the committed changes.

bz mentioned this in rS302143: PFSTATE_NOSYNC goes onto state_flags, not sync_state;.

Ack, obviously correct.

Strangely a Dxxxx in the commit message now also closes things ... nice ... and unexpected.

Closed by commit rS302157: PFSTATE_NOSYNC goes onto state_flags, not sync_state; (authored by bz). · Explain WhyJun 23 2016, 9:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

2 lines

Diff 17820

pf_ioctl.c

Loading...