asmc: rename wol sysctl to auto_poweron
ClosedPublic
Actions

Authored by guest-seuros on Thu, Apr 30, 2:11 PM.

Details

Reviewers

adrian
ziaee
ngie

Commits

rG36b399f55e3f: asmc: rename wol sysctl to auto_poweron

Summary

Older SMC firmware exposed AUPO as a Wake-on-LAN control. On updated
firmware, the key controls automatic power-on when AC power is restored
after a power loss; WoL is handled by the GBE controller instead.
Rename the sysctl to reflect the current semantics. No compatibility
alias is provided as the sysctl has not appeared in any release.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 72739
Build 69622: arc lint + arc unit

Event Timeline

guest-seuros created this revision.Thu, Apr 30, 2:11 PM

guest-seuros held this revision as a draft.

Herald added subscribers: ziaee, imp. · View Herald TranscriptThu, Apr 30, 2:11 PM

Harbormaster completed remote builds in B72672: Diff 176902.Thu, Apr 30, 2:11 PM

guest-seuros updated this revision to Diff 176903.Thu, Apr 30, 2:12 PM

This comment was removed by guest-seuros.

Harbormaster completed remote builds in B72673: Diff 176903.Thu, Apr 30, 2:12 PM

guest-seuros published this revision for review.Thu, Apr 30, 2:13 PM

guest-seuros added reviewers: adrian, ziaee.

guest-seuros added a reviewer: ngie.Thu, Apr 30, 2:55 PM

How do you handle the case of older firmware? Won't this driver still use this for wake on lan?

share/man/man4/asmc.4
2	Please do not remove line one, just remove the hyphen. This is for consistency with C comments and in accordance with our style guides.

In D56747#1299757, @ziaee wrote:

How do you handle the case of older firmware? Won't this driver still use this for wake on lan?

Older firmware still works fine with this change.

I tested this on an older firmware (circa 2011–2012) and didn’t hit any regression. I cant re-test it now though; the machine updated its SMC/firmware and there is no downgrade path.

This change is really about correctness.
AUPO means Auto UP (Or something similar), not Wake-on-LAN. The current WOL naming that i introduced is misleading.

please fix the hyphen and then this'll be fine to land, thanks!

imp added inline comments.Fri, May 1, 8:12 PM

share/man/man4/asmc.4
3	I'm not sure this change warrants a new copyright in this case... It's just a small tweak to the overall page.

ziaee requested changes to this revision.Fri, May 1, 8:12 PM

This revision now requires changes to proceed.Fri, May 1, 8:12 PM

linting

Harbormaster completed remote builds in B72739: Diff 177068.Sun, May 3, 11:38 AM

guest-seuros marked 2 inline comments as done.Sun, May 3, 11:44 AM

guest-seuros added inline comments.

share/man/man4/asmc.4
3	The copyright line was not added for this specific change, I have been modifying this file over the past four months as part of broader apple SMC work. Since this particular diff is a small rename, I agree it does not warrant adding a copyright, and have removed it.