libzpool: Set -Wno-error=typedef-redefinition for clang
ClosedPublic
Actions

Authored by ivy on Apr 27 2026, 3:49 AM.

Details

Reviewers

dim
emaste

Group Reviewers

ZFS

Commits

rG036ff38ebd5a: libzpool: Set -Wno-error=typedef-redefinition for clang

Summary

In some versions of LLVM (at least 21), the <*intrin.h> headers contain
unguarded duplicate typedefs; this isn't permitted prior to C11, and
libzpool is built as C99. FreeBSD's LLVM backported LLVM PR #153820
to fix this, but other versions of LLVM (e.g., upstream, or on Linux)
don't have the patch, so this breaks the build.

Add -Wno-error=typedef-redefinition to downgrade this from an error
to a warning.

Sponsored by: https://www.patreon.com/bsdivy

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72561
Build 69444: arc lint + arc unit

Event Timeline

ivy created this revision.Apr 27 2026, 3:49 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 27 2026, 3:49 AM

ivy requested review of this revision.Apr 27 2026, 3:49 AM

Harbormaster completed remote builds in B72561: Diff 176601.Apr 27 2026, 3:49 AM

If this doesn't happen too often across the tree, I'm fine with this approach. If there are more, it may make sense to put a generic macro (e.g. NO_WTYPEDEF_REDEFINITION) in bsd.sys.mk, like we have done for some other annoying warnings.

This revision is now accepted and ready to land.Apr 27 2026, 11:32 AM

emaste accepted this revision.Apr 27 2026, 12:56 PM

In D56653#1297844, @dim wrote:

If this doesn't happen too often across the tree, I'm fine with this approach. If there are more, it may make sense to put a generic macro (e.g. NO_WTYPEDEF_REDEFINITION) in bsd.sys.mk, like we have done for some other annoying warnings.

this is the only case i found when testing this, and the only other existing use is in tools/build/mk/Makefile.boot which is a little special, so i think we're fine just inlining this here. i do wonder if we couldn't instead build OpenZFS as C17 like the rest of the system...