tests: Manually assign the tests distribution
Needs ReviewPublic
Actions

Authored by jlduran on Apr 23 2026, 5:50 AM.

Details

Reviewers

None

Group Reviewers

Summary

These Makefiles do not include bsd.test.mk because they do not contain
tests (i.e., they do not need a Kyuafile). They should be however, part
of the test distribution.

Manually assign the distribution, otherwise these files will get
assigned to the default base distribution (base.txz instead of
tests.txz).

Test Plan

This is part of a larger effort to reconcile freebsd-base(7) packages
with distributions (legacy).

In preparation for NanoBSD Reimagined (GSoC 2026).

The test plan is to compare the mtree output of both images, one built
using just the FreeBSD-set-base package and the other one built using
just the base.txz distribution sets.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72463
Build 69346: arc lint + arc unit

Event Timeline

jlduran created this revision.Apr 23 2026, 5:50 AM

Herald added a reviewer: melifaro. · View Herald TranscriptApr 23 2026, 5:50 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, donner and 3 others. · View Herald Transcript

jlduran requested review of this revision.Apr 23 2026, 5:50 AM

Harbormaster completed remote builds in B72463: Diff 176237.Apr 23 2026, 5:50 AM

Hi @senguptaangshuman17_gmail.com, this revision is still missing a few tests. I plan to add them after this week's meeting.

jlduran removed a reviewer: melifaro.Apr 23 2026, 5:53 AM

lib/libc/tests/stdlib/dynthr_mod/Makefile
sbin/pfctl/tests/files/Makefile

these are extra in here.

In D56597#1344151, @senguptaangshuman17_gmail.com wrote:

lib/libc/tests/stdlib/dynthr_mod/Makefile
sbin/pfctl/tests/files/Makefile

these are extra in here.

Please double check:

# cd /tmp
/tmp # fetch https://download.freebsd.org/snapshots/amd64/16.0-CURRENT/base.txz
base.txz                                               166 MB ...
/tmp # tar -c -f - --format=mtree @base.txz | grep dynthr_mod.so
./usr/tests/lib/libc/stdlib/dynthr_mod.so nlink=0 gname=wheel uname=root time=1785224674.0 mode=444 gid=0 uid=0 type=file size=4472
/tmp # tar -c -f - --format=mtree @base.txz | grep sbin/pfctl/files
./usr/tests/sbin/pfctl/files gname=wheel uname=root time=1785224626.0 mode=755 gid=0 uid=0 type=dir
./usr/tests/sbin/pfctl/files/pf0001.in nlink=0 gname=wheel uname=root time=1785224570.0 mode=444 gid=0 uid=0 type=file size=387
./usr/tests/sbin/pfctl/files/pf0001.ok nlink=0 gname=wheel uname=root time=1785224611.0 mode=444 gid=0 uid=0 type=file size=567
...

jlduran added a reviewer: releng.Sat, Aug 1, 3:51 PM

In D56597#1344514, @jlduran wrote:

In D56597#1344151, @senguptaangshuman17_gmail.com wrote:

lib/libc/tests/stdlib/dynthr_mod/Makefile
sbin/pfctl/tests/files/Makefile

these are extra in here.

Please double check:

# cd /tmp
/tmp # fetch https://download.freebsd.org/snapshots/amd64/16.0-CURRENT/base.txz
base.txz                                               166 MB ...
/tmp # tar -c -f - --format=mtree @base.txz | grep dynthr_mod.so
./usr/tests/lib/libc/stdlib/dynthr_mod.so nlink=0 gname=wheel uname=root time=1785224674.0 mode=444 gid=0 uid=0 type=file size=4472
/tmp # tar -c -f - --format=mtree @base.txz | grep sbin/pfctl/files
./usr/tests/sbin/pfctl/files gname=wheel uname=root time=1785224626.0 mode=755 gid=0 uid=0 type=dir
./usr/tests/sbin/pfctl/files/pf0001.in nlink=0 gname=wheel uname=root time=1785224570.0 mode=444 gid=0 uid=0 type=file size=387
./usr/tests/sbin/pfctl/files/pf0001.ok nlink=0 gname=wheel uname=root time=1785224611.0 mode=444 gid=0 uid=0 type=file size=567
...

Actually I meant is the local commit that I had in the nanobsd-pkgbase branch had these 2 file changes missing in it. Those have been added in this commit.