libiscsiutil: preserve errno across warning logs
ClosedPublic
Actions

Authored by kevans on Apr 21 2026, 4:41 AM.

Tags

None

Referenced Files

	F175583818: D56539.id.diff
	Sun, Oct 11, 8:23 PM

	F175569131: D56539.id175947.diff
	Sun, Oct 11, 6:40 PM

	Unknown Object (File)
	Wed, Oct 7, 6:42 AM

	Unknown Object (File)
	Wed, Oct 7, 4:12 AM

	Unknown Object (File)
	Tue, Oct 6, 10:04 PM

	Unknown Object (File)
	Tue, Oct 6, 8:30 PM

	Unknown Object (File)
	Tue, Oct 6, 8:19 PM

	Unknown Object (File)
	Thu, Oct 1, 5:31 AM

View All 98 Files

Subscribers

imp

Details

Reviewers

asomers
jhb

Commits

rGfe9d81d7c660: libiscsiutil: preserve errno across warning logs

Summary

Various calls in the implementation can clobber errno; preserve it for
the caller since none of these will bubble up pass/fail to simplify
some future error handling in ctld.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72388
Build 69271: arc lint + arc unit

Event Timeline

kevans created this revision.Apr 21 2026, 4:41 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 21 2026, 4:41 AM

kevans requested review of this revision.Apr 21 2026, 4:41 AM

Harbormaster completed remote builds in B72388: Diff 175947.Apr 21 2026, 4:41 AM

kevans added a child revision: D56540: ctl: add a new error type to distinguish EINVAL vs. EEXIST.Apr 21 2026, 4:41 AM

jhb accepted this revision.Apr 23 2026, 4:30 PM

This revision is now accepted and ready to land.Apr 23 2026, 4:30 PM

Closed by commit rGfe9d81d7c660: libiscsiutil: preserve errno across warning logs (authored by kevans). · Explain WhyApr 28 2026, 8:52 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGfe9d81d7c660: libiscsiutil: preserve errno across warning logs.

Revision Contents
Changeset List

Path

Size

lib/

libiscsiutil/

log.c

4 lines

Diff 175947

View Options

libiscsiutil: preserve errno across warning logsClosedPublicActions