libiscsiutil: preserve errno across warning logs
Needs ReviewPublic
Actions

Authored by kevans on Tue, Apr 21, 4:41 AM.

Details

Reviewers

asomers
jhb

Summary

Various calls in the implementation can clobber errno; preserve it for
the caller since none of these will bubble up pass/fail to simplify
some future error handling in ctld.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72388
Build 69271: arc lint + arc unit

Event Timeline

kevans created this revision.Tue, Apr 21, 4:41 AM

Herald added a subscriber: imp. · View Herald TranscriptTue, Apr 21, 4:41 AM

kevans requested review of this revision.Tue, Apr 21, 4:41 AM

Harbormaster completed remote builds in B72388: Diff 175947.Tue, Apr 21, 4:41 AM

kevans added a child revision: D56540: ctl: add a new error type to distinguish EINVAL vs. EEXIST.Tue, Apr 21, 4:41 AM

Revision Contents
Changeset List

Path

Size

lib/

libiscsiutil/

log.c

4 lines

Diff 175947

View Options

libiscsiutil: preserve errno across warning logsNeeds ReviewPublicActions