libiscsiutil: preserve errno across warning logs
ClosedPublic
Actions

Authored by kevans on Apr 21 2026, 4:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 16, 4:16 PM

	Unknown Object (File)
	Sat, May 16, 4:11 PM

	Unknown Object (File)
	Thu, May 14, 3:40 PM

	Unknown Object (File)
	Thu, May 14, 9:48 AM

	Unknown Object (File)
	Thu, May 14, 4:35 AM

	Unknown Object (File)
	Mon, May 11, 2:05 PM

	Unknown Object (File)
	Sun, May 10, 6:36 PM

	Unknown Object (File)
	Sun, May 10, 12:15 PM

View All 25 Files

Subscribers

imp

Details

Reviewers

asomers
jhb

Commits

rGfe9d81d7c660: libiscsiutil: preserve errno across warning logs

Summary

Various calls in the implementation can clobber errno; preserve it for
the caller since none of these will bubble up pass/fail to simplify
some future error handling in ctld.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Apr 21 2026, 4:41 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 21 2026, 4:41 AM

kevans requested review of this revision.Apr 21 2026, 4:41 AM

Harbormaster completed remote builds in B72388: Diff 175947.Apr 21 2026, 4:41 AM

kevans added a child revision: D56540: ctl: add a new error type to distinguish EINVAL vs. EEXIST.Apr 21 2026, 4:41 AM

jhb accepted this revision.Thu, Apr 23, 4:30 PM

This revision is now accepted and ready to land.Thu, Apr 23, 4:30 PM

Closed by commit rGfe9d81d7c660: libiscsiutil: preserve errno across warning logs (authored by kevans). · Explain WhyTue, Apr 28, 8:52 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGfe9d81d7c660: libiscsiutil: preserve errno across warning logs.

Revision Contents
Changeset List

Path

Size

lib/

libiscsiutil/

log.c

4 lines

Diff 176763

View Options

libiscsiutil: preserve errno across warning logsClosedPublicActions